Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to DOMSettableTokenList #11578

Closed
nox opened this issue Jun 3, 2016 · 6 comments
Closed

Remove references to DOMSettableTokenList #11578

nox opened this issue Jun 3, 2016 · 6 comments
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-cleanup No impact; the issue is one of maintainability or tidiness.

Comments

@nox
Copy link
Contributor

nox commented Jun 3, 2016

This interface doesn't exist anymore and was removed from the DOM spec.

Files:

  • components/script/dom/webidls/HTMLAnchorElement.webidl
  • components/script/dom/webidls/HTMLAreaElement.webidl
  • components/script/dom/webidls/HTMLElement.webidl
  • components/script/dom/webidls/HTMLIFrameElement.webidl
  • components/script/dom/webidls/HTMLLinkElement.webidl
  • components/script/dom/webidls/HTMLOutputElement.webidl
  • components/script/dom/webidls/HTMLTableCellElement.webidl
  • tests/wpt/metadata/dom/interface-objects.html.ini
  • tests/wpt/metadata/dom/interfaces.html.ini
  • tests/wpt/web-platform-tests/dom/historical.htm
@nox nox added A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-cleanup No impact; the issue is one of maintainability or tidiness. labels Jun 3, 2016
@highfive
Copy link

highfive commented Jun 3, 2016

Please make a comment here if you intend to work on this issue. Thank you!

@nox
Copy link
Contributor Author

nox commented Jun 3, 2016

This entails looking at the definitions of the WebIDL interfaces in the various specs and updating them to not reference DOMSettableTokenList anymore.

@kevgs
Copy link
Contributor

kevgs commented Jun 3, 2016

I'll take this one.

@nox nox added the C-assigned There is someone working on resolving the issue label Jun 3, 2016
@kevgs kevgs mentioned this issue Jun 4, 2016
Merged
5 tasks
@nox
Copy link
Contributor Author

nox commented Jun 4, 2016

Blocks #2185.

bors-servo pushed a commit that referenced this issue Jun 4, 2016
Auto merge of #11606 - kevgs:dom_settable_token_list, r=nox
8605c14 
Removed references to DOMSettableTokenList

<!-- Please describe your changes on the following line: -->
PR to #11578

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11606)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jun 5, 2016
Auto merge of #11606 - kevgs:dom_settable_token_list, r=nox
dabb9c2 
Removed references to DOMSettableTokenList

<!-- Please describe your changes on the following line: -->
PR to #11578

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11606)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jun 5, 2016
Auto merge of #11606 - kevgs:dom_settable_token_list, r=nox
d801d41 
Removed references to DOMSettableTokenList

<!-- Please describe your changes on the following line: -->
PR to #11578

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11606)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jun 5, 2016
Auto merge of #11606 - kevgs:dom_settable_token_list, r=nox
490087d 
Removed references to DOMSettableTokenList

<!-- Please describe your changes on the following line: -->
PR to #11578

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11606)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jun 5, 2016
Auto merge of #11606 - kevgs:dom_settable_token_list, r=nox
44126da 
Removed references to DOMSettableTokenList

<!-- Please describe your changes on the following line: -->
PR to #11578

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11606)
<!-- Reviewable:end -->
@timvandermeij
Copy link
Contributor

Fixed by #11606?

@nox
Copy link
Contributor Author

nox commented Jun 6, 2016

Yes.

@nox nox closed this as completed Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-cleanup No impact; the issue is one of maintainability or tidiness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nox @timvandermeij @kevgs @highfive