layout: Re-enable parallel layout and refactor boxes significantly #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Critic review: https://critic.hoppipolla.co.uk/r/1318 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
pcwalton
changed the title
|
Added a small commit to fix up a safety issue that I realized we have. |
|
Left a few comments on critic |
|
@SimonSapin It's meant to be "based on top of" #2141, but I'll just close it. |
|
I’ve edited the PR message to add "Closes #2018". Hopefully GitHub will do its magic. |
| /// New-line chracter(\n)'s positions(relative, not absolute) | ||
| /// | ||
| /// FIXME(pcwalton): This is very inefficient; remove. |
There was a problem hiding this comment.
Note to self: #2260
|
re-r? @SimonSapin. I had to fix an issue in border styles. |
|
re-r? @SimonSapin Filed #2288. |
from `Flow`s; in the process, remove `InlineInfo` in favor of the range-based design that was originally planned and halfway implemented. Now, the DOM tree structure for inline flows is reflected not by a series of arrays but instead by a flat list of ranges into the list of boxes. As part of this, the `border` and `padding` fields, which were incorrect in the case of inlines and necessitated separate `noncontent_inline_foo` methods, have been merged into a single `border_padding` field that is always guaranteed to be correct after width assignment, even for inlines.
bors-servo
pushed a commit
that referenced
this pull request
May 2, 2014
layout: Re-enable parallel layout by removing all `RefCell` instances from `Flow`s; in the process, remove `InlineInfo` in favor of the range-based design that was originally planned and halfway implemented. Now, the DOM tree structure for inline flows is reflected not by a series of arrays but instead by a flat list of ranges into the list of boxes. As part of this, the `border` and `padding` fields, which were incorrect in the case of inlines and necessitated separate `noncontent_inline_foo` methods, have been merged into a single `border_padding` field that is always guaranteed to be correct after width assignment, even for inlines. r? @SimonSapin and/or @larsbergstrom Closes #1280 Closes #1926 Closes #1999 Closes #2013 Closes #2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
layout: Re-enable parallel layout by removing all
RefCellinstances fromFlows; in the process, removeInlineInfoin favor of the range-based design that was originally planned and halfway implemented.Now, the DOM tree structure for inline flows is reflected not by a
series of arrays but instead by a flat list of ranges into the list of
boxes. As part of this, the
borderandpaddingfields, which wereincorrect in the case of inlines and necessitated separate
noncontent_inline_foomethods, have been merged into a singleborder_paddingfield that is always guaranteed to be correct afterwidth assignment, even for inlines.
r? @SimonSapin and/or @larsbergstrom
Closes #1280
Closes #1926
Closes #1999
Closes #2013
Closes #2018