WPT html/semantics/form/form-submission-0/form-submission-algorithm.html appears to navigate to a set iframe.src despite a subsequent form.submit() targeting the iframe #25154
Labels
A-content/dom
Interacting with the DOM from web content
Projects
Comments
bors-servo
pushed a commit
that referenced
this issue
Dec 10, 2019
Workarounds for form-submission-0 tests with about:blank onloads <!-- Please describe your changes on the following line: --> Following the model of 3b9ab34 these changes replace some naive onload events with equivalents that do nothing if they see an about:blank load event. Two test cases now pass, and one failing test case is now failing for a less ambiguous reason (#25154) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25151 and fix #25152. <!-- Either: --> - [X] These changes do not require tests because these are fixes to tests only, not code changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
pushed a commit
that referenced
this issue
Dec 10, 2019
Workarounds for form-submission-0 tests with about:blank onloads <!-- Please describe your changes on the following line: --> Following the model of 3b9ab34 these changes replace some naive onload events with equivalents that do nothing if they see an about:blank load event. Two test cases now pass, and one failing test case is now failing for a less ambiguous reason (#25154) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25151 and fix #25152. <!-- Either: --> - [X] These changes do not require tests because these are fixes to tests only, not code changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is the last test, "Cannot navigate (after constructing the entry list)".
This test sets up iframe.onload, then sets iframe.src, then calls form.submit (with form targeting iframe). The onload appears to see the url from the src, not from the submit.
If I take out the line that sets src, then the onload from the submit does appear to happen.
The text was updated successfully, but these errors were encountered: