Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing action in CreateContextualFragment method #14210

Merged
merged 1 commit into from Nov 21, 2016
Merged

Add missing action in CreateContextualFragment method #14210

merged 1 commit into from Nov 21, 2016

Conversation

GuillaumeGomez
Copy link
Contributor

@GuillaumeGomez GuillaumeGomez commented Nov 14, 2016 •
edited by larsbergstrom

r? @nox

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/htmlscriptelement.rs, components/script/dom/range.rs
  • @KiChjang: components/script/dom/htmlscriptelement.rs, components/script/dom/range.rs

@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 14, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 15, 2016

Test please :)

@jdm jdm added the S-needs-tests New tests have been requested by a reviewer. label Nov 15, 2016
@nox
Copy link
Contributor

nox commented Nov 16, 2016

18:38 <nox> imperio: The code is exactly what I wanted, but it should pass more tests with it so I'll have to experiment locally.

@GuillaumeGomez
Copy link
Contributor Author

Updated.

@nox
Copy link
Contributor

nox commented Nov 17, 2016

Please squash everything. The only separate commit I wanted was for the whitespace-only changes in expectations.

@nox nox added S-needs-squash Some (or all) of the commits in the PR should be combined. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-tests New tests have been requested by a reviewer. labels Nov 17, 2016
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 17, 2016
@GuillaumeGomez
Copy link
Contributor Author

Updated.

@nox
Copy link
Contributor

nox commented Nov 18, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 2f1073e has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-squash Some (or all) of the commits in the PR should be combined. labels Nov 18, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 2f1073e with merge 172b4c2...

bors-servo pushed a commit that referenced this pull request Nov 18, 2016
Auto merge of #14210 - GuillaumeGomez:fragment_node, r=nox
172b4c2 
Add missing action in CreateContextualFragment method

r? @nox

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14210)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 18, 2016
@highfive
Copy link 

  ▶ Unexpected subtest result in /old-tests/submission/Opera/script_scheduling/117.html:
  └ PASS [expected FAIL] scheduler: inline script created with createContextualFragment

  ▶ Unexpected subtest result in /old-tests/submission/Opera/script_scheduling/118.html:
  └ PASS [expected FAIL] scheduler: external script created with createContextualFragment

@nox
Copy link
Contributor

nox commented Nov 18, 2016

Nice, more passing tests. ^

@GuillaumeGomez
Copy link
Contributor Author

Urg.

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 18, 2016
@nox
Copy link
Contributor

nox commented Nov 18, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 861bcb2 has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 18, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 861bcb2 with merge 2d4a4be...

bors-servo pushed a commit that referenced this pull request Nov 18, 2016
Auto merge of #14210 - GuillaumeGomez:fragment_node, r=nox
2d4a4be 
Add missing action in CreateContextualFragment method

r? @nox

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14210)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 18, 2016
@highfive
Copy link 

  ▶ FAIL [expected PASS] /_mozilla/css/incremental_trailing_whitespace_a.html
  └   → /_mozilla/css/incremental_trailing_whitespace_a.html da54041086f2975f8e3c776d2283ad6609e6862a
/_mozilla/css/incremental_trailing_whitespace_ref.html f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b
Testing da54041086f2975f8e3c776d2283ad6609e6862a == f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b

@nox
Copy link
Contributor

nox commented Nov 18, 2016

@bors-servo retry #10473

bors-servo pushed a commit that referenced this pull request Nov 18, 2016
Auto merge of #14210 - GuillaumeGomez:fragment_node, r=nox
6a59d33 
Add missing action in CreateContextualFragment method

r? @nox

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14210)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit 861bcb2 with merge 6a59d33...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 18, 2016
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt1

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 18, 2016
@nox
Copy link
Contributor

nox commented Nov 21, 2016

@bors-servo retry #11100

@bors-servo
Copy link
Contributor

⌛ Testing commit 861bcb2 with merge d562d10...

bors-servo pushed a commit that referenced this pull request Nov 21, 2016
Auto merge of #14210 - GuillaumeGomez:fragment_node, r=nox
d562d10 
Add missing action in CreateContextualFragment method

r? @nox

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14210)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 21, 2016
@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

@bors-servo bors-servo merged commit 861bcb2 into servo:master Nov 21, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 21, 2016
@GuillaumeGomez GuillaumeGomez deleted the fragment_node branch November 21, 2016 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@GuillaumeGomez @highfive @Ms2ger @nox @bors-servo @jdm