-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermittent failure in /_mozilla/css/incremental_trailing_whitespace_a.html #10473
Comments
My internet's too slow. Can someone copy-paste the log into the reftest analyzer and capture a screenshot? |
Seems like the border isn't rendered, probably an incremental layout bug. cc @mbrubeck |
:( I was afraid of this. See #10246 (comment) for details. We should probably disable this until #10245 is implemented, and see if that can make it more reliable. |
Filed #11069 to disable. |
Disable /_mozilla/css/incremental_trailing_whitespace_a.html CC #10473 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11069) <!-- Reviewable:end -->
Can't we just spinloop for 200ms or something? Edit: nevermind you addressed that in the other ticket. |
Wait, we support transitionend now right? So we can just wait for that event in the test. |
Yes. |
@jdm According to http://testthewebforward.org/docs/reftests.html, we can't actually wait for anything in a reftest in Servo, given we don't support mutation observers, no? :( |
We have the |
No @emilio, we don't support mutation observers.
|
We support reftest-wait in rust code |
PR to disable: #14288. |
Disable incremental_trailing_whitespace_a.html. CC #10473. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14288) <!-- Reviewable:end -->
Disable incremental_trailing_whitespace_a.html. CC #10473. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14288) <!-- Reviewable:end -->
This test is still disabled. |
Oops. |
This is no longer disabled in layout 2020, so I'm going to close this one. |
▶ FAIL [expected PASS] /_mozilla/css/incremental_trailing_whitespace_a.html
└ → /_mozilla/css/incremental_trailing_whitespace_a.html da54041086f2975f8e3c776d2283ad6609e6862a
/_mozilla/css/incremental_trailing_whitespace_ref.html f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b
Testing da54041086f2975f8e3c776d2283ad6609e6862a == f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b
The text was updated successfully, but these errors were encountered: