Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent failure in /_mozilla/css/incremental_trailing_whitespace_a.html #10473

Closed
wafflespeanut opened this issue Apr 8, 2016 · 16 comments
Closed

Intermittent failure in /_mozilla/css/incremental_trailing_whitespace_a.html #10473

wafflespeanut opened this issue Apr 8, 2016 · 16 comments
Labels
A-content/css Interacting with CSS from web content (parsing, serializing, introspection) A-layout/incremental C-disabled The issue describes an intermittent failure in a test, which has been temporarily disabled I-intermittent Problem reproduces intermittently.

Comments

@wafflespeanut
Copy link
Contributor

▶ FAIL [expected PASS] /_mozilla/css/incremental_trailing_whitespace_a.html
└ → /_mozilla/css/incremental_trailing_whitespace_a.html da54041086f2975f8e3c776d2283ad6609e6862a
/_mozilla/css/incremental_trailing_whitespace_ref.html f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b
Testing da54041086f2975f8e3c776d2283ad6609e6862a == f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b
@wafflespeanut wafflespeanut added A-content/css Interacting with CSS from web content (parsing, serializing, introspection) I-intermittent Problem reproduces intermittently. labels Apr 8, 2016
@wafflespeanut
Copy link
Contributor Author

My internet's too slow. Can someone copy-paste the log into the reftest analyzer and capture a screenshot?

@wafflespeanut wafflespeanut mentioned this issue Apr 8, 2016
Merged
@emilio
Copy link
Member

emilio commented Apr 8, 2016

Seems like the border isn't rendered, probably an incremental layout bug.

incremental-trailing-whitespace

cc @mbrubeck

@mbrubeck
Copy link
Contributor

mbrubeck commented Apr 8, 2016

:( I was afraid of this. See #10246 (comment) for details. We should probably disable this until #10245 is implemented, and see if that can make it more reliable.

@jdm jdm mentioned this issue Apr 11, 2016
Merged
@emilio emilio mentioned this issue Apr 11, 2016
Merged
This was referenced Apr 15, 2016
Merged
Merged
Merged
Merged
@jdm jdm mentioned this issue Apr 23, 2016
Merged
@notriddle notriddle mentioned this issue Apr 23, 2016
Merged
@frewsxcv frewsxcv mentioned this issue May 3, 2016
Merged
@Ms2ger Ms2ger mentioned this issue May 7, 2016
Merged
@mbrubeck mbrubeck self-assigned this May 7, 2016
mbrubeck added a commit to mbrubeck/servo that referenced this issue May 7, 2016
@mbrubeck
Disable /_mozilla/css/incremental_trailing_whitespace_a.html
915aab1 
CC servo#10473
@mbrubeck mbrubeck mentioned this issue May 7, 2016
Merged
@mbrubeck
Copy link
Contributor

mbrubeck commented May 7, 2016

Filed #11069 to disable.

@mbrubeck mbrubeck removed their assignment May 7, 2016
bors-servo pushed a commit that referenced this issue May 7, 2016
Auto merge of #11069 - mbrubeck:disable-incremental-trailing, r=mbrubeck
508c328 
Disable /_mozilla/css/incremental_trailing_whitespace_a.html

CC #10473

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11069)
<!-- Reviewable:end -->
@jdm jdm added the C-disabled The issue describes an intermittent failure in a test, which has been temporarily disabled label May 8, 2016
zakorgy pushed a commit to zakorgy/servo that referenced this issue May 26, 2016
@mbrubeck @zakorgy
Disable /_mozilla/css/incremental_trailing_whitespace_a.html
ceb8883 
CC servo#10473
@metajack metajack mentioned this issue Jul 12, 2016
Open
18 tasks
@jdm jdm mentioned this issue Aug 26, 2016
Merged
This was referenced Oct 13, 2016
Merged
Merged
This was referenced Nov 18, 2016
Merged
Merged
@KiChjang KiChjang mentioned this issue Nov 18, 2016
Merged
5 tasks
@canova canova mentioned this issue Nov 18, 2016
Merged
4 tasks
@nox nox mentioned this issue Nov 19, 2016
Merged
@nox
Copy link
Contributor

nox commented Nov 19, 2016 •
edited
Loading

Can't we just spinloop for 200ms or something? Edit: nevermind you addressed that in the other ticket.

@nox
Copy link
Contributor

nox commented Nov 19, 2016

Wait, we support transitionend now right? So we can just wait for that event in the test.

@jdm
Copy link
Member

jdm commented Nov 19, 2016

Yes.

This was referenced Nov 19, 2016
Merged
Merged
@nox
Copy link
Contributor

nox commented Nov 19, 2016

@jdm According to http://testthewebforward.org/docs/reftests.html, we can't actually wait for anything in a reftest in Servo, given we don't support mutation observers, no? :(

@emilio
Copy link
Member

emilio commented Nov 19, 2016 •
edited by nox
Loading

We have the reftest-wait classname in the HTML element, isn't that enough?

@nox
Copy link
Contributor

nox commented Nov 19, 2016

No @emilio, we don't support mutation observers.

technical note: the implementation in wptrunner uses mutation observers so the screenshot will be triggered in the microtask checkpoint after the class is removed

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 19, 2016

We support reftest-wait in rust code

@nox nox mentioned this issue Nov 19, 2016
Merged
@Manishearth Manishearth mentioned this issue Nov 19, 2016
Merged
@stshine stshine mentioned this issue Nov 19, 2016
Merged
4 tasks
Ms2ger added a commit that referenced this issue Nov 20, 2016
@Ms2ger
Disable incremental_trailing_whitespace_a.html.
6de630a 
CC #10473.
@Ms2ger Ms2ger mentioned this issue Nov 20, 2016
Merged
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 20, 2016

PR to disable: #14288.

@Ms2ger Ms2ger added the C-disabled The issue describes an intermittent failure in a test, which has been temporarily disabled label Nov 20, 2016
bors-servo pushed a commit that referenced this issue Nov 20, 2016
Auto merge of #14288 - servo:incr, r=Ms2ger
64de73d 
Disable incremental_trailing_whitespace_a.html.

CC #10473.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14288)
<!-- Reviewable:end -->
@heycam heycam mentioned this issue Nov 20, 2016
Merged
bors-servo pushed a commit that referenced this issue Nov 20, 2016
Auto merge of #14288 - servo:incr, r=Ms2ger
78e3e2c 
Disable incremental_trailing_whitespace_a.html.

CC #10473.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14288)
<!-- Reviewable:end -->
@nox
Copy link
Contributor

nox commented Oct 1, 2017

This test is still disabled.

@nox nox closed this as completed Oct 1, 2017
@nox nox reopened this Oct 1, 2017
@nox
Copy link
Contributor

nox commented Oct 1, 2017

Oops.

@mrobinson
Copy link
Member

This is no longer disabled in layout 2020, so I'm going to close this one.

@mrobinson mrobinson closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/css Interacting with CSS from web content (parsing, serializing, introspection) A-layout/incremental C-disabled The issue describes an intermittent failure in a test, which has been temporarily disabled I-intermittent Problem reproduces intermittently.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@mbrubeck @mrobinson @jdm @Ms2ger @nox @emilio @KiChjang @wafflespeanut