Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FnvHasher in http_loader::load #14284

Merged
merged 1 commit into from Nov 20, 2016
Merged

Use FnvHasher in http_loader::load #14284

merged 1 commit into from Nov 20, 2016

Conversation

@nox
Copy link
Member

nox commented Nov 19, 2016 •
edited by larsbergstrom

Should help with #11100.

This change is Reviewable
@nox
Use FnvHasher in http_loader::load
Loading status checks…
7a8c5ae 
Should help with #11100.
@highfive
Copy link

highfive commented Nov 19, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/Cargo.toml, components/net/lib.rs, components/net/http_loader.rs
  • @emilio: ports/geckolib/Cargo.lock
@highfive
Copy link

highfive commented Nov 19, 2016

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member Author

nox commented Nov 19, 2016

@bors-servo p=1
@wafflespeanut
Copy link
Member

wafflespeanut commented Nov 19, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2016

📌 Commit 7a8c5ae has been approved by Wafflespeanut
@highfive highfive assigned wafflespeanut and unassigned jdm Nov 19, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 19, 2016

I doubt it'll help, this code is only used for unit tests now.
@nox
Copy link
Member Author

nox commented Nov 19, 2016

I don't know, the other usage of RNG in there is using Uuid. Removing the default hasher at the very least cannot hurt, right?
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 19, 2016

Are you looking at the first comment of the linked issue? That's from before the current situation.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2016

⌛ Testing commit 7a8c5ae with merge 795ce92...
bors-servo added a commit that referenced this pull request Nov 19, 2016
@bors-servo
Auto merge of #14284 - nox:fnv, r=Wafflespeanut
Loading status checks…
795ce92 
Use FnvHasher in http_loader::load

Should help with #11100.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14284)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2016

💔 Test failed - linux-rel-wpt
@highfive
Copy link

highfive commented Nov 19, 2016 

  ▶ FAIL [expected PASS] /_mozilla/css/incremental_trailing_whitespace_a.html
  └   → /_mozilla/css/incremental_trailing_whitespace_a.html da54041086f2975f8e3c776d2283ad6609e6862a
/_mozilla/css/incremental_trailing_whitespace_ref.html f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b
Testing da54041086f2975f8e3c776d2283ad6609e6862a == f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b
@nox
Copy link
Member Author

nox commented Nov 19, 2016

@bors-servo retry #10473
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2016

💔 Test failed - linux-rel-wpt
@nox
Copy link
Member Author

nox commented Nov 19, 2016

@bors-servo retry #14267
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2016

⌛ Testing commit 7a8c5ae with merge 7e34f4c...
bors-servo added a commit that referenced this pull request Nov 20, 2016
@bors-servo
Auto merge of #14284 - nox:fnv, r=Wafflespeanut
Loading status checks…
7e34f4c 
Use FnvHasher in http_loader::load

Should help with #11100.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14284)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 7a8c5ae into servo:master Nov 20, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Nov 20, 2016
Merged
0 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wafflespeanut wafflespeanut

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @wafflespeanut @bors-servo @Ms2ger @jdm
You can’t perform that action at this time.