New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use FnvHasher in http_loader::load #14284
Conversation
Should help with servo#11100.
@bors-servo p=1 |
@bors-servo r+ |
📌 Commit 7a8c5ae has been approved by |
I doubt it'll help, this code is only used for unit tests now. |
I don't know, the other usage of RNG in there is using Uuid. Removing the default hasher at the very least cannot hurt, right? |
Are you looking at the first comment of the linked issue? That's from before the current situation. |
Use FnvHasher in http_loader::load Should help with #11100. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14284) <!-- Reviewable:end -->
💔 Test failed - linux-rel-wpt |
|
@bors-servo retry #10473 |
⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only linux-rel-wpt... |
💔 Test failed - linux-rel-wpt |
@bors-servo retry #14267 |
Use FnvHasher in http_loader::load Should help with #11100. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14284) <!-- Reviewable:end -->
☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev |
Should help with #11100.
This change is