Reverse Number and LengthOrPercentage in LengthOrPercentageOrNumber #16646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"0" must be parsed as the number 0, not the unitless 0px length.
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
@bors-servo r+ |
|
📌 Commit 193e1d5 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Apr 28, 2017
Reverse Number and LengthOrPercentage in LengthOrPercentageOrNumber "0" must be parsed as the number 0, not the unitless 0px length. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16646) <!-- Reviewable:end -->
|
💔 Test failed - mac-rel-wpt1 |
highfive
added
S-tests-failed
|
@bors-servo retry #16649 |
bors-servo
pushed a commit
that referenced
this pull request
Apr 29, 2017
Reverse Number and LengthOrPercentage in LengthOrPercentageOrNumber "0" must be parsed as the number 0, not the unitless 0px length. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16646) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"0" must be parsed as the number 0, not the unitless 0px length.
This change is