Skip to content

Improve Style Sharing #17110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 31, 2017
Merged

Improve Style Sharing #17110

merged 3 commits into from
May 31, 2017

Conversation

bholley
Copy link
Contributor

@bholley bholley commented May 31, 2017 •
edited by larsbergstrom
Loading

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @emilio: components/style/sharing/mod.rs, components/style/sharing/checks.rs, components/style/context.rs, components/style/stylist.rs

@bholley
Copy link
Contributor Author

bholley commented May 31, 2017

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit 47404cf has been approved by emilio

@highfive highfive assigned emilio and unassigned pcwalton May 31, 2017
@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 31, 2017
@bholley
Copy link
Contributor Author

bholley commented May 31, 2017

@bors-servo p=1

@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 31, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 47404cf with merge 1b9cc2d...

bors-servo pushed a commit that referenced this pull request May 31, 2017
Auto merge of #17110 - bholley:better_style_sharing, r=emilio
1b9cc2d 
Improve Style Sharing

Reviewed in:
https://bugzilla.mozilla.org/show_bug.cgi?id=1368665
https://bugzilla.mozilla.org/show_bug.cgi?id=1368399

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17110)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 31, 2017
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 1b9cc2d to master...

@bors-servo bors-servo merged commit 47404cf into servo:master May 31, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bholley @highfive @bors-servo @pcwalton @emilio