Convert TrackList's values field to store only TrackSize.
#17737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was storing both TrackSize and TrackRepeat before and TrackRepeat have to be converted into sequence of TrackSize during serialization. Instead of doing this in serialization process(which is hard and hacky), we converted to do this in parsing process. We were doing this conversion in the ComputedValue conversion. So we only had to move this process to parsing.
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
|
|
r? @wafflespeanut, @Manishearth |
Manishearth
approved these changes
Jul 14, 2017
|
LGTM, since this is just refactoring existing code. r=me after try build succeeds. |
|
@bors-servo r=Manishearth,wafflespeanut |
|
📌 Commit ade76f1 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jul 14, 2017
…h,wafflespeanut Convert TrackList's `values` field to store only TrackSize. It was storing both TrackSize and TrackRepeat before and TrackRepeat have to be converted into sequence of TrackSize during serialization. Instead of doing this in serialization process(which is hard and hacky), we converted to do this in parsing process. We were doing this conversion in the ComputedValue conversion. So we only had to move this process to parsing. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17737) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 15, 2017
weilonge
pushed a commit
to weilonge/gecko
that referenced
this pull request
Jul 15, 2017
aethanyc
pushed a commit
to aethanyc/gecko-dev
that referenced
this pull request
Jul 17, 2017
JerryShih
pushed a commit
to JerryShih/gecko-dev
that referenced
this pull request
Jul 17, 2017
Manishearth
pushed a commit
to Manishearth/gecko-dev
that referenced
this pull request
Jul 18, 2017
leobalter
pushed a commit
to leobalter/gecko-dev
that referenced
this pull request
Jul 20, 2017
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
UltraBlame original commit: e84711b4665d4f9bd64c35db94f926ab8da60e8d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
UltraBlame original commit: e84711b4665d4f9bd64c35db94f926ab8da60e8d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
UltraBlame original commit: e84711b4665d4f9bd64c35db94f926ab8da60e8d
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was storing both TrackSize and TrackRepeat before and TrackRepeat have to be
converted into sequence of TrackSize during serialization. Instead of doing this
in serialization process(which is hard and hacky), we converted to do this in
parsing process. We were doing this conversion in the ComputedValue conversion.
So we only had to move this process to parsing.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is