New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermittent mac timeout due to missing font URLs (No URL for Core Text font!) #24622
Labels
Projects
Comments
jdm
added
A-platform/fonts
P-mac
Any version of MacOS
I-intermittent
Problem reproduces intermittently.
labels
Nov 1, 2019
4 tasks
5 tasks
5 tasks
4 tasks
This was referenced Dec 12, 2019
4 tasks
This was referenced Jan 3, 2020
This was referenced Jan 13, 2020
This was referenced Jan 17, 2020
5 tasks
5 tasks
This was referenced Jul 4, 2020
This was referenced Jul 6, 2020
This was referenced Jul 17, 2020
This was referenced Jul 24, 2020
This was referenced Aug 4, 2020
bors-servo
added a commit
that referenced
this issue
Aug 7, 2020
Canvas text and macOS font fixes These changes work around a source of panics by skipping glyphs that don't exist when drawing text to the canvas. Ideally we would have font fallback and/or tofu characters, but that's a larger project than I wanted to get into right now. Relatedly, while investigating the non-panic errors observed in #27476, I realized that the underlying source of #24622 could be dealt with because we shouldn't actually need to open the CTFont by a file path to get the bytes, since we already have bytes available that we use to create the CTFont. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24622 and fix #27476 and fix the panic observed in #20445. - [x] There are tests for these changes
bors-servo
added a commit
that referenced
this issue
Aug 7, 2020
Canvas text and macOS font fixes These changes work around a source of panics by skipping glyphs that don't exist when drawing text to the canvas. Ideally we would have font fallback and/or tofu characters, but that's a larger project than I wanted to get into right now. Relatedly, while investigating the non-panic errors observed in #27476, I realized that the underlying source of #24622 could be dealt with because we shouldn't actually need to open the CTFont by a file path to get the bytes, since we already have bytes available that we use to create the CTFont. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24622 and fix #27476 and fix the panic observed in #20445. - [x] There are tests for these changes
bors-servo
added a commit
that referenced
this issue
Aug 7, 2020
Canvas text and macOS font fixes These changes work around a source of panics by skipping glyphs that don't exist when drawing text to the canvas. Ideally we would have font fallback and/or tofu characters, but that's a larger project than I wanted to get into right now. Relatedly, while investigating the non-panic errors observed in #27476, I realized that the underlying source of #24622 could be dealt with because we shouldn't actually need to open the CTFont by a file path to get the bytes, since we already have bytes available that we use to create the CTFont. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24622 and fix #27476 and fix the panic observed in #20445. - [x] There are tests for these changes
Merged
This was referenced Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
This affects lots of different tests, so I'm not adding any tests to the summary.
The text was updated successfully, but these errors were encountered: