Implement Event.composedPath #31123

Taym95 · 2024-01-18T17:27:50Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix Implement Event.composedPath #31007

There are tests for these changes OR

github-actions · 2024-01-18T20:41:59Z

🔨 Triggering try run (#7575738371) with platforms=linux and layout=all

github-actions · 2024-01-18T21:32:41Z

Test results for linux-wpt-layout-2013 from try job (#7575738371):

Flaky unexpected result (13)

OK /_mozilla/css/transitionend_event.html
- FAIL [expected PASS] subtest: transitionend_event assert_unreached: Reached unreachable code
CRASH [expected OK] /_mozilla/mozilla/service-workers/service-worker-registration.https.html (#31036)
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- FAIL [expected PASS] subtest: listeners are called correct number of times assert_equals: expected 7 but got 6
- FAIL [expected PASS] subtest: removing listener from one MQL doesn't remove it from all MQLs assert_equals: expected 1 but got 0
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- FAIL [expected PASS] subtest: border-image sec-fetch-site - HTTPS downgrade (header not sent) assert_unreached: Reached unreachable code
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
- PASS [expected FAIL] subtest: Navigating to a different document with form submission
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
TIMEOUT /resource-timing/test_resource_timing.html (#25720)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
TIMEOUT /resource-timing/test_resource_timing.https.html (#25216)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img) assert_equals: expected 19629056 but got 19628800
OK [expected TIMEOUT] /webmessaging/without-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe Test timed out
OK /workers/WorkerGlobalScope-close.html (#23064)
- PASS [expected FAIL] subtest: Test sending a message after closing.

Stable unexpected results that are known to be intermittent (19)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/CSS2/linebox/inline-negative-margin-001.html (#23862)
- PASS [expected FAIL] subtest: [data-expected-height] 1
- PASS [expected FAIL] subtest: [data-expected-height] 2
- FAIL [expected PASS] subtest: [data-expected-height] 4 assert_equals:
  <div class="w4" data-expected-height="10">123 <span style="margin-left: -4ch">123 </span></div>
  height expected 10 but got 20
OK /css/cssom-view/MediaQueryList-extends-EventTarget-interop.html (#25285)
- FAIL [expected PASS] subtest: listener added with addListener and addEventListener is called once assert_equals: triggerMQLEvent expected 1 but got 0
OK /css/cssom-view/offsetTopLeft-border-box.html (#24237)
- PASS [expected FAIL] subtest: container: 0
- PASS [expected FAIL] subtest: container: 1
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
FAIL [expected CRASH] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
OK [expected TIMEOUT] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-empty.html (#28259)
- FAIL [expected TIMEOUT] subtest: Autofocus elements in top-level browsing context's documents with empty fragments should work. assert_not_equals: got disallowed value Element node <body></body>
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped Test timed out
- NOTRUN [expected TIMEOUT] subtest: Area element should support autofocus
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- FAIL [expected PASS] subtest: text/plain: Basic File test (formdata event) assert_equals: expected "basic=file-test.txt\r\n" but got ""
- FAIL [expected PASS] subtest: text/plain: single quote in value (formdata event) assert_equals: expected "a=b'c\r\n" but got ""
OK /html/semantics/forms/historical.html (#28568)
- PASS [expected FAIL] subtest: <input name=isindex> should not be supported
OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- FAIL [expected PASS] subtest: Check that rel=noopener with target=_self does a normal load this.openedWindow.findLink is not a function
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- PASS [expected TIMEOUT] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document
OK [expected TIMEOUT] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry-different-function-realm.html (#25805)
- FAIL [expected TIMEOUT] subtest: Fulfillment handler on pending-then-fulfilled promise assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/function/resources/window-to-open.html" but got "about:blank"
- FAIL [expected TIMEOUT] subtest: Rejection handler on pending-then-rejected promise assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/function/resources/window-to-open.html" but got "about:blank"
OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)

Stable unexpected results (2)

OK /dom/idlharness.any.worker.html
- PASS [expected FAIL] subtest: Event interface: operation composedPath()
- PASS [expected FAIL] subtest: Event interface: new Event("foo") must inherit property "composedPath()" with the proper type
- PASS [expected FAIL] subtest: Event interface: new CustomEvent("foo") must inherit property "composedPath()" with the proper type
OK /dom/idlharness.window.html?exclude=Node
- PASS [expected FAIL] subtest: Event interface: operation composedPath()
- PASS [expected FAIL] subtest: Event interface: document.createEvent("Event") must inherit property "composedPath()" with the proper type
- PASS [expected FAIL] subtest: Event interface: new Event("foo") must inherit property "composedPath()" with the proper type
- PASS [expected FAIL] subtest: Event interface: new CustomEvent("foo") must inherit property "composedPath()" with the proper type

github-actions · 2024-01-18T21:34:26Z

Test results for linux-wpt-layout-2020 from try job (#7575738371):

Flaky unexpected result (13)

FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
TIMEOUT [expected PASS] /_mozilla/css/transition_calc_implicit.html (#17417)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/cssom-view/MediaQueryList-addListener-handleEvent.html (#24571)
- FAIL [expected PASS] subtest: calls handleEvent method of event listener assert_equals: expected (object) object "[object Object]" but got (undefined) undefined
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html
TIMEOUT /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-no-beforeunload.window.html (#29055)
- TIMEOUT [expected FAIL] subtest: Navigating an opened window with an iframe via location.href to a javascript: URL must not fire beforeunload on the iframe: undefined completion Test timed out
- NOTRUN [expected PASS] subtest: Navigating an iframe via location.href to a javascript: URL must not fire beforeunload: string completion
- NOTRUN [expected PASS] subtest: Navigating an iframe via src="" to a javascript: URL after insertion must not fire beforeunload: string completion
- NOTRUN [expected TIMEOUT] subtest: Navigating an opened window via location.href to a javascript: URL must not fire beforeunload: string completion
TIMEOUT [expected OK] /html/browsers/browsing-the-web/read-media/pageload-image-in-popup.html (#23849)
- NOTRUN [expected FAIL] subtest: The document for a standalone media file should have one child in the body.
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 1 (expected array [6, 3] got [6, 1])
FAIL [expected PASS] /html/rendering/non-replaced-elements/the-page/iframe-scrolling-attribute-values.html
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used Test timed out
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry-different-function-realm.html (#25805)
- TIMEOUT [expected FAIL] subtest: Fulfillment handler on fulfilled promise Test timed out
- TIMEOUT [expected FAIL] subtest: Rejection handler on rejected promise Test timed out

Stable unexpected results that are known to be intermittent (16)

CRASH [expected PASS] /_webgl/conformance/glsl/bugs/long-expressions-should-not-crash.html (#19221)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- PASS [expected FAIL] subtest: Matching font-weight: '400' should prefer '501 550' over '502 560'
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '500' over '450 460' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '400' over '350 399' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-weight: '399' should prefer '500 501' over '502 510'
- FAIL [expected PASS] subtest: Matching font-stretch: '100%' should prefer '100%' over '110% 120%' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-stretch: '110%' should prefer '105%' over '100%' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-style: 'normal' should prefer 'normal' over 'oblique 0deg'
- FAIL [expected PASS] subtest: Matching font-style: 'normal' should prefer 'oblique 20deg 30deg' over 'oblique -50deg -20deg' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'oblique 30deg 60deg' over 'oblique 40deg 50deg' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-style: 'italic' should prefer 'oblique 5deg' over 'normal'
- And 7 more unexpected results...
OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
- FAIL [expected PASS] subtest: Smooth scrolling while doing history navigation. assert_not_equals: Shouldn't be scrolled back to top yet. got disallowed value 0
OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/about-srcdoc-navigation-blocked.window.html (#31025)
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='' assert_unreached: load should not be fired Reached unreachable code
OK /html/browsers/browsing-the-web/navigating-across-documents/navigate-to-unparseable-url.html (#29050)
- FAIL [expected PASS] subtest: <a> tag navigate fails for unparseable URLs promise_test: Unhandled rejection with value: object "Error: Navigation was attempted to unparseable URL"
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"
OK /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
- PASS [expected FAIL] subtest: first argument: absolute url
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- FAIL [expected PASS] subtest: application/x-www-form-urlencoded: 0x00 in value (formdata event) assert_equals: expected "a=b%00c" but got ""
OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- PASS [expected FAIL] subtest: Check that rel=noopener with target=_self does a normal load
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- FAIL [expected PASS] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document assert_equals: expected "/html/webappapis/scripting/events/resources/open-window.html" but got "blank"
TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out
OK [expected ERROR] /workers/semantics/run-a-worker/003.html (#22765)

Stable unexpected results (2)

OK /dom/idlharness.any.worker.html
- PASS [expected FAIL] subtest: Event interface: operation composedPath()
- PASS [expected FAIL] subtest: Event interface: new Event("foo") must inherit property "composedPath()" with the proper type
- PASS [expected FAIL] subtest: Event interface: new CustomEvent("foo") must inherit property "composedPath()" with the proper type
OK /dom/idlharness.window.html?exclude=Node
- PASS [expected FAIL] subtest: Event interface: operation composedPath()
- PASS [expected FAIL] subtest: Event interface: document.createEvent("Event") must inherit property "composedPath()" with the proper type
- PASS [expected FAIL] subtest: Event interface: new Event("foo") must inherit property "composedPath()" with the proper type
- PASS [expected FAIL] subtest: Event interface: new CustomEvent("foo") must inherit property "composedPath()" with the proper type

github-actions · 2024-01-18T21:34:57Z

⚠️ Try run (#7575738371) failed.

Taym95 · 2024-01-19T17:17:41Z

@gterzian @mrobinson I test it on https://www.w3schools.com/jsreF/tryit.asp?filename=tryjsref_event_composedpath

works and seems to give same result as Chrome and Firefox for event path, do you think this enough or I should do more?

gterzian

Great work, thanks!

Couple of comments, and regarding the tests:

I would expect this one to not error anymore:

servo/tests/wpt/meta/dom/events/relatedTarget.window.js.ini

Line 2 in 8dcf3dd

expected: ERROR
There are some tests for this in the shadow-dom folder, which is currently skipped. It makes sense to unskip the folder by way of changes to include.ini to see if any tests are passing.

components/script/dom/event.rs

tests/wpt/mozilla/meta/mozilla/service-workers/service-worker-registration.https.html.ini

components/script/dom/event.rs

Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>

Taym95 · 2024-01-22T13:30:43Z

Great work, thanks!

Couple of comments, and regarding the tests:

I would expect this one to not error anymore:

servo/tests/wpt/meta/dom/events/relatedTarget.window.js.ini

Line 2 in 8dcf3dd

expected: ERROR

There are some tests for this in the shadow-dom folder, which is currently skipped. It makes sense to unskip the folder by way of changes to include.ini to see if any tests are passing.

Thanks @gterzian

For 1 I am still getting:

Error at http://web-platform.test:8000/dom/events/relatedTarget.window.js:5:21 host.attachShadow is not a function

for 2 maybe I am doing something wrong but I don't see [shadow-dom] skipped in include.ini

gterzian

LGTM, I would say we leave the shadom-dom tests alone for now, because it looks like we are missing support for most of it so it is not worth it to unskip those tests. By the way they are skipped by default, so unskipping them means adding skip: false to the .ini file...

Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>

github-actions · 2024-01-23T12:18:06Z

🔨 Triggering try run (#7625578364) with platforms=linux and layout=all

github-actions · 2024-01-23T13:27:56Z

Test results for linux-wpt-layout-2020 from try job (#7625578364):

Flaky unexpected result (16)

CRASH [expected PASS] /_webgl/conformance/glsl/bugs/long-expressions-should-not-crash.html (#19221)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected FAIL] /css/css-text/overflow-wrap/overflow-wrap-break-word-006.html
TIMEOUT /css/cssom-view/MediaQueryList-extends-EventTarget.html (#25269)
- FAIL [expected PASS] subtest: onchange adds listener promise_test: Unhandled rejection with value: object "TypeError: _event is undefined"
OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/about-srcdoc-navigation-blocked.window.html (#31025)
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- PASS [expected FAIL] subtest: Check execution order on load handler
- PASS [expected FAIL] subtest: Check execution order from nested timeout
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
OK /html/interaction/focus/the-autofocus-attribute/document-with-fragment-valid.html (#28259)
- PASS [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with URL fragments should be skipped.
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used Test timed out
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task Test timed out
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: Basic File test (formdata event)
- PASS [expected FAIL] subtest: text/plain: 0x00 in value (formdata event)
- PASS [expected FAIL] subtest: text/plain: \n in name (normal form)
OK [expected TIMEOUT] /webmessaging/with-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out
OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)
OK [expected ERROR] /workers/semantics/run-a-worker/003.html (#22765)

Stable unexpected results that are known to be intermittent (16)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
PASS [expected FAIL] /css/css-flexbox/dynamic-baseline-change.html (#29234)
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- PASS [expected FAIL] subtest: Matching font-weight: '400' should prefer '450 460' over '500'
- FAIL [expected PASS] subtest: Matching font-weight: '400' should prefer '351 398' over '501 550' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '500' over '450 460' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '400' over '350 399' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-stretch: '110%' should prefer '105%' over '100%' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-style: 'normal' should prefer 'oblique 20deg 30deg' over 'oblique -50deg -20deg' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'oblique 30deg 60deg' over 'oblique 40deg 50deg' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-style: 'italic' should prefer 'normal' over 'oblique 0deg'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 21deg' should prefer 'oblique 20deg' over 'oblique 10deg'
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 10deg' should prefer 'oblique 10deg' over 'oblique 5deg' assert_equals: Unexpected font on test element expected 487 but got 532
- And 5 more unexpected results...
OK /css/cssom-view/MediaQueryList-addListener-handleEvent.html (#24571)
- FAIL [expected PASS] subtest: looks up handleEvent method on every event dispatch assert_equals: expected 2 but got 1
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent) Test timed out
TIMEOUT /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-origin destination, no attributes
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
OK /html/browsers/browsing-the-web/navigating-across-documents/navigate-to-unparseable-url.html (#29050)
- FAIL [expected PASS] subtest: <a> tag navigate fails for unparseable URLs promise_test: Unhandled rejection with value: object "Error: Navigation was attempted to unparseable URL"
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: Basic File test (formdata event)
- FAIL [expected PASS] subtest: application/x-www-form-urlencoded: 0x00 in value (formdata event) assert_equals: expected "a=b%00c" but got ""
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- TIMEOUT [expected PASS] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document Test timed out
TIMEOUT /resource-timing/test_resource_timing.html (#25720)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img) assert_equals: expected 18126336 but got 18126080
TIMEOUT [expected OK] /webmessaging/without-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript: Test timed out

github-actions · 2024-01-23T13:32:37Z

Test results for linux-wpt-layout-2013 from try job (#7625578364):

Flaky unexpected result (15)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected FAIL] /css/css-animations/animation-delay-010.html (#26573)
TIMEOUT [expected OK] /custom-elements/reactions/customized-builtins/HTMLMediaElement.html (#31014)
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent) Test timed out
- FAIL [expected PASS] subtest: border-image sec-fetch-site - HTTPS downgrade (header not sent) assert_unreached: Reached unreachable code
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
TIMEOUT /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-no-beforeunload.window.html (#29055)
- TIMEOUT [expected FAIL] subtest: Navigating an opened window with an iframe via location.href to a javascript: URL must not fire beforeunload on the iframe: undefined completion Test timed out
- NOTRUN [expected PASS] subtest: Navigating an iframe via location.href to a javascript: URL must not fire beforeunload: string completion
- NOTRUN [expected PASS] subtest: Navigating an iframe via src="" to a javascript: URL after insertion must not fire beforeunload: string completion
- NOTRUN [expected TIMEOUT] subtest: Navigating an opened window via location.href to a javascript: URL must not fire beforeunload: string completion
OK /html/browsers/browsing-the-web/navigating-across-documents/navigate-to-unparseable-url.html (#29050)
- PASS [expected FAIL] subtest: <a> tag navigate fails for unparseable URLs
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"
OK [expected TIMEOUT] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
TIMEOUT /resource-timing/test_resource_timing.html (#25720)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
TIMEOUT [expected OK] /webmessaging/with-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out
OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:

Stable unexpected results that are known to be intermittent (15)

CRASH [expected PASS] /_webgl/conformance/glsl/bugs/long-expressions-should-not-crash.html (#19221)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/CSS2/linebox/inline-negative-margin-001.html (#23862)
- PASS [expected FAIL] subtest: [data-expected-height] 1
- PASS [expected FAIL] subtest: [data-expected-height] 2
- FAIL [expected PASS] subtest: [data-expected-height] 4 assert_equals:
  <div class="w4" data-expected-height="10">123 <span style="margin-left: -4ch">123 </span></div>
  height expected 10 but got 20
OK /css/cssom-view/offsetTopLeft-border-box.html (#24237)
- PASS [expected FAIL] subtest: container: 0
- PASS [expected FAIL] subtest: container: 1
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- FAIL [expected PASS] subtest: Same-origin navigation started from unload handler must be ignored assert_equals: expected "?pass" but got "?fail"
CRASH [expected PASS] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-empty.html (#28259)
- FAIL [expected TIMEOUT] subtest: Autofocus elements in top-level browsing context's documents with empty fragments should work. assert_not_equals: got disallowed value Element node <body></body>
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Area element should support autofocus assert_equals: expected Element node <area></area> but got Element node <body>
  <img src="/media/poster.png" usemap="#map">
  <map n...
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- FAIL [expected PASS] subtest: text/plain: Basic File test (formdata event) assert_equals: expected "basic=file-test.txt\r\n" but got ""
- FAIL [expected PASS] subtest: text/plain: single quote in value (formdata event) assert_equals: expected "a=b'c\r\n" but got ""
OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- FAIL [expected PASS] subtest: Check that rel=noopener with target=_self does a normal load this.openedWindow.findLink is not a function
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- FAIL [expected TIMEOUT] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document assert_equals: expected "/html/webappapis/scripting/events/resources/open-window.html" but got "blank"
OK [expected TIMEOUT] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry-different-function-realm.html (#25805)
- FAIL [expected TIMEOUT] subtest: Fulfillment handler on pending-then-fulfilled promise assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/function/resources/window-to-open.html" but got "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/relevant/resources/window-to-open.html"
- FAIL [expected TIMEOUT] subtest: Rejection handler on pending-then-rejected promise assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/function/resources/window-to-open.html" but got "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/relevant/resources/window-to-open.html"
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe Test timed out

github-actions · 2024-01-23T13:33:05Z

✨ Try run (#7625578364) succeeded.

Taym95 marked this pull request as draft January 18, 2024 17:27

mrobinson added T-linux-wpt-2013 Do a try run of the WPT (legacy layout) T-linux-wpt-2020 Do a try run of the WPT labels Jan 18, 2024

github-actions bot removed T-linux-wpt-2013 Do a try run of the WPT (legacy layout) T-linux-wpt-2020 Do a try run of the WPT labels Jan 18, 2024

Implement Event.composedPath

4a71a39

Taym95 force-pushed the Implement-Event.composedPath branch 2 times, most recently from 72f576a to 2157266 Compare January 19, 2024 15:44

Taym95 marked this pull request as ready for review January 19, 2024 17:18

gterzian requested changes Jan 22, 2024

View reviewed changes

components/script/dom/event.rs Outdated Show resolved Hide resolved

components/script/dom/event.rs Show resolved Hide resolved

tests/wpt/mozilla/meta/mozilla/service-workers/service-worker-registration.https.html.ini Outdated Show resolved Hide resolved

mrobinson reviewed Jan 22, 2024

View reviewed changes

components/script/dom/event.rs Outdated Show resolved Hide resolved

Taym95 added 2 commits January 22, 2024 11:58

Implement Event.composedPath

7654d35

Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>

Use documentation comments for EventMethods

f7a4429

Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>

Taym95 force-pushed the Implement-Event.composedPath branch from 2157266 to f7a4429 Compare January 22, 2024 11:18

Taym95 mentioned this pull request Jan 22, 2024

Handle shadow roots for event path #31149

Open

gterzian approved these changes Jan 23, 2024

View reviewed changes

gterzian added this pull request to the merge queue Jan 23, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2024

Update wpt test expectations

5ba44b2

Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>

mrobinson added T-linux-wpt-2013 Do a try run of the WPT (legacy layout) T-linux-wpt-2020 Do a try run of the WPT labels Jan 23, 2024

github-actions bot removed T-linux-wpt-2013 Do a try run of the WPT (legacy layout) T-linux-wpt-2020 Do a try run of the WPT labels Jan 23, 2024

mrobinson added this pull request to the merge queue Jan 23, 2024

Merged via the queue into servo:main with commit 5d7e2a8 Jan 23, 2024
65 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Event.composedPath #31123

Implement Event.composedPath #31123

Taym95 commented Jan 18, 2024 •

edited

Loading

github-actions bot commented Jan 18, 2024

github-actions bot commented Jan 18, 2024

github-actions bot commented Jan 18, 2024

github-actions bot commented Jan 18, 2024

Taym95 commented Jan 19, 2024 •

edited

Loading

gterzian left a comment

Taym95 commented Jan 22, 2024

gterzian left a comment

github-actions bot commented Jan 23, 2024

github-actions bot commented Jan 23, 2024

github-actions bot commented Jan 23, 2024

github-actions bot commented Jan 23, 2024

Implement Event.composedPath #31123

Implement Event.composedPath #31123

Conversation

Taym95 commented Jan 18, 2024 • edited Loading

github-actions bot commented Jan 18, 2024

github-actions bot commented Jan 18, 2024

github-actions bot commented Jan 18, 2024

github-actions bot commented Jan 18, 2024

Taym95 commented Jan 19, 2024 • edited Loading

gterzian left a comment

Choose a reason for hiding this comment

Taym95 commented Jan 22, 2024

gterzian left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 23, 2024

github-actions bot commented Jan 23, 2024

github-actions bot commented Jan 23, 2024

github-actions bot commented Jan 23, 2024

Taym95 commented Jan 18, 2024 •

edited

Loading

Taym95 commented Jan 19, 2024 •

edited

Loading