Skip to content

Conversation

iterminatorheart
Copy link
Contributor


  • There are tests for these changes OR
  • These changes do not require tests because ___

@sagudev sagudev requested a review from delan April 7, 2024 19:50
@iterminatorheart iterminatorheart force-pushed the feat/status_tooltip branch 5 times, most recently from 35ce190 to 3a49a89 Compare April 12, 2024 13:26
Copy link
Member

@delan delan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is coming along well! A few comments:

Copy link
Member

@atbrakhi atbrakhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iterminatorheart your changes looks good. I have rebased the PR and addressed delan's comment. We should be able to land this.

@atbrakhi atbrakhi force-pushed the feat/status_tooltip branch from 3627275 to b0ed6dd Compare May 21, 2024 10:29
@delan delan self-requested a review May 21, 2024 10:36
@delan delan enabled auto-merge May 21, 2024 10:36
@delan delan added this pull request to the merge queue May 21, 2024
Merged via the queue into servo:main with commit 9d57c0d May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

servoshell: show a status bar tooltip when hovering over links
4 participants