New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make caches document-aware #3485

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@squarewave
Copy link
Contributor

squarewave commented Jan 8, 2019

For document splitting

Bugzilla bug: 1441308


This change is Reviewable

@squarewave squarewave force-pushed the squarewave:docsplitting branch from 1db45d7 to 216b569 Jan 8, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 9, 2019

☔️ The latest upstream changes (presumably #3488) made this pull request unmergeable. Please resolve the merge conflicts.

@gw3583

This comment has been minimized.

Copy link
Collaborator

gw3583 commented Jan 9, 2019

@gw3583 gw3583 requested a review from bholley Jan 9, 2019

@squarewave squarewave force-pushed the squarewave:docsplitting branch from 216b569 to 91abc30 Jan 9, 2019

Doug Thayer added some commits Nov 28, 2018

Doug Thayer
Make TextureCache document-aware
This change makes the TextureCache segment its cached data by
document, so that documents' data are not evicted out from underneath them.

Differential Revision: https://phabricator.services.mozilla.com/D13343
Doug Thayer
Add option to disable texture cache clear
To facilitate testing of document splitting before it is preffed on,
I'm adding an option to disable clearing the texture cache, since this
will currently crash the browser with doc splitting on.

Differential Revision: https://phabricator.services.mozilla.com/D13841
Doug Thayer
Make GpuCache document-aware
GpuCache can currently evict things out from underneath docs which
are not updating this frame. This makes its roots document-specific,
so that we only evict items for currently updating documents.

Differential Revision: https://phabricator.services.mozilla.com/D13840

@squarewave squarewave force-pushed the squarewave:docsplitting branch from 91abc30 to f7cb7ce Jan 9, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 9, 2019

☔️ The latest upstream changes (presumably #3493) made this pull request unmergeable. Please resolve the merge conflicts.

@staktrace

This comment has been minimized.

Copy link
Contributor

staktrace commented Jan 11, 2019

These patches were merged in #3501 so we can close this PR (I apparently don't have permissions to do it)

@bholley bholley closed this Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment