Make caches document-aware #3485
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squarewave
force-pushed
the
docsplitting
branch
from
1db45d7 to
216b569
Compare
|
☔ The latest upstream changes (presumably #3488) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? @bholley |
squarewave
force-pushed
the
docsplitting
branch
from
216b569 to
91abc30
Compare
This change makes the TextureCache segment its cached data by document, so that documents' data are not evicted out from underneath them. Differential Revision: https://phabricator.services.mozilla.com/D13343
GpuCache can currently evict things out from underneath docs which are not updating this frame. This makes its roots document-specific, so that we only evict items for currently updating documents. Differential Revision: https://phabricator.services.mozilla.com/D13840
To facilitate testing of document splitting before it is preffed on, I'm adding an option to disable clearing the texture cache, since this will currently crash the browser with doc splitting on. Differential Revision: https://phabricator.services.mozilla.com/D13841
squarewave
force-pushed
the
docsplitting
branch
from
91abc30 to
f7cb7ce
Compare
|
☔ The latest upstream changes (presumably #3493) made this pull request unmergeable. Please resolve the merge conflicts. |
|
These patches were merged in #3501 so we can close this PR (I apparently don't have permissions to do it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For document splitting
Bugzilla bug: 1441308
This change is