Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise with top-level modules vcf2zarr, plink2zarr #40

Closed
jeromekelleher opened this issue Feb 26, 2024 · 0 comments · Fixed by #198
Closed

Reorganise with top-level modules vcf2zarr, plink2zarr #40

jeromekelleher opened this issue Feb 26, 2024 · 0 comments · Fixed by #198
Milestone

Comments

@jeromekelleher
Copy link
Contributor

The Python API that's emerging is to do things like:

from bio2zarr import vcf

vcf.convert(["my_file.vcf.gz", "out.zarr")

It would probably be better to do it like

from bio2zarr import vcf2zarr

vcf2zarr.convert(["my_file.vcf.gz", "out.zarr")

Then, all the functions exported are in that flat namespace vcf2zarr. How stuff is split across files within the package is private.

@jeromekelleher jeromekelleher added this to the 0.1.0 release milestone May 2, 2024
jeromekelleher added a commit to jeromekelleher/bio2zarr that referenced this issue May 13, 2024
jeromekelleher added a commit to jeromekelleher/bio2zarr that referenced this issue May 14, 2024
jeromekelleher added a commit to jeromekelleher/bio2zarr that referenced this issue May 14, 2024
jeromekelleher added a commit to jeromekelleher/bio2zarr that referenced this issue May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant