Skip to content

Commit

Permalink
Upgrade to ddev 1.18.2 (#105)
Browse files Browse the repository at this point in the history
* ddev support gitpod, no need for special config
  • Loading branch information
shaal authored Dec 9, 2021
1 parent dd3ebdb commit a978565
Show file tree
Hide file tree
Showing 5 changed files with 481 additions and 569 deletions.
48 changes: 0 additions & 48 deletions .ddev/gitpod-setup-ddev.sh

This file was deleted.

45 changes: 14 additions & 31 deletions .gitpod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,13 @@ image:
# ddev and composer are running as part of the prebuild
# when starting a workspace all docker images are ready
tasks:
- name: Terminal
init: |
export DDEV_NONINTERACTIVE=true
.ddev/gitpod-setup-ddev.sh
- init: |
ddev start -y
ddev composer install
ddev drush si -y --account-pass=admin --site-name='ddev_gitpod' demo_umami
command: |
.ddev/gitpod-setup-ddev.sh
ddev start -y
ddev composer install
gp await-port 8080 && gp preview $(gp url 8080)
Expand All @@ -23,45 +22,29 @@ vscode:
- ziyasal.vscode-open-in-github

ports:
# Used by ddev - local db clients
- port: 3306
onOpen: ignore
# Used by projector
- port: 6942
onOpen: ignore
visibility: private
# Direct-connect ddev-webserver port that is the main port
- port: 8080
onOpen: ignore
visibility: private
# Currently un-notified and unsupported mailhog http port
- port: 8025
# Used by MailHog
- port: 8027
onOpen: ignore
visibility: private
# Currently un-notified and unsupported mailhog https port
- port: 8026
onOpen: ignore
visibility: private
# Currently un-notified and unsupported phpmyadmin http port
# Used by phpMyAdmin
- port: 8036
onOpen: ignore
visibility: private
# Currently un-notified and unsupported phpmyadmin https port
- port: 8037
onOpen: ignore
visibility: private
# router http port that we're ignoring.
- port: 8888
# Direct-connect ddev-webserver port that is the main port
- port: 8080
onOpen: ignore
visibility: private
# router https port that we're ignoring.
- port: 8889
# Ignore host https port
- port: 8443
onOpen: ignore
visibility: private
# xdebug port
- port: 9000
onOpen: ignore
visibility: private
# projector port
- port: 9999
visibility: private

github:
prebuilds:
Expand All @@ -76,7 +59,7 @@ github:
# add a check to pull requests (defaults to true)
addCheck: true
# add a "Review in Gitpod" button as a comment to pull requests (defaults to false)
addComment: true
addComment: false
# add a "Review in Gitpod" button to the pull request's description (defaults to false)
addBadge: true
# add a label once the prebuild is ready to pull requests (defaults to false)
Expand Down
Loading

0 comments on commit a978565

Please sign in to comment.