Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mozilla Social API integration #101

Closed
qwertygc opened this issue Jan 15, 2015 · 10 comments
Closed

Mozilla Social API integration #101

qwertygc opened this issue Jan 15, 2015 · 10 comments
Labels
Milestone

Comments

@qwertygc
Copy link

Mozilla à sorti Social API (https://developer.mozilla.org/fr/docs/Social_API). Pourquoi pas faire un plugin pour shaarli ?

@nodiscc
Copy link
Member

nodiscc commented Jan 15, 2015

Avec quelles fonctionalités? Un bouton share? (shaarli a déjà un bookmarklet) Une sidebar shaarli? J'ai un peu testé les démos et je vois mal ce que ça apporte pour l'instant. Si quelqu'un peut m'éclairer...

@nodiscc nodiscc changed the title Social API Mozilla Social API integration Jan 15, 2015
@qwertygc
Copy link
Author

En gros, c'est comme le bouton share, mais tout est regroupé au sein d'un seul bouton, on gagne de la place ^^

@nodiscc
Copy link
Member

nodiscc commented Jan 19, 2015

I have read a bit about Firefox's Social API. Existing services are listed here: https://activations.cdn.mozilla.net/en-US/
I has the benefit of grouping all social media accounts under one toolbar button and/or sidebar.
However, the implementation seems complex (https://developer.mozilla.org/en-US/docs/tag/Social; https://github.com/mixedpuppy/socialapi-demo -what?) and it's not cross-browser. So this should be added as a plugin if someone wants to work on it.

@e2jk
Copy link

e2jk commented Feb 18, 2015

I have created a page to list all plugin ideas, and listed this plugin suggestion there.
I'm closing this issue, please reopen if anyone wants to work on it (or just create a Pull Request and we're done with it ;) )

@e2jk e2jk closed this as completed Feb 18, 2015
@nodiscc
Copy link
Member

nodiscc commented Feb 18, 2015

@e2jk Thanks, I think it makes sense to close plugin requests that we are no one is willing to work on right now.

The closest to what could be added to Shaarli is the Pocket service for Mozilla Social API.

@nodiscc nodiscc added this to the future milestone May 11, 2015
@nodiscc
Copy link
Member

nodiscc commented May 11, 2015

Reopening to make issue visible in issues list (cleaning up the Ideas for plugins wiki page)

@nodiscc nodiscc reopened this May 11, 2015
@Marsup
Copy link

Marsup commented May 11, 2015

@nodiscc I just did it, it was quite simple honestly, about 20 lines of code, I'm not sure it's worth a plugin. Should I proceed with a PR ?

@nodiscc
Copy link
Member

nodiscc commented May 11, 2015

about 20 lines of code
Should I proceed with a PR

@Marsup Please yes. If it doesn't add much complexity and works as expected, it can be merged.

@Marsup
Copy link

Marsup commented May 11, 2015

How do I run the tests if any ? Just making sure I didn't break anything.

@nodiscc
Copy link
Member

nodiscc commented May 11, 2015

You can send your pull request and it will be manually reviewed and tested for some time before the merge.

We don't have a clear test procedure currently, we just make sure all Shaarli features are working correctly (yes a list would be nice) and wait for #71 and #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants