Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firefox Social API to the tools. Fixes #101. #213

Merged
merged 1 commit into from
May 22, 2015
Merged

Add Firefox Social API to the tools. Fixes #101. #213

merged 1 commit into from
May 22, 2015

Conversation

Marsup
Copy link

@Marsup Marsup commented May 11, 2015

As discussed in #101, here comes the PR.

The wording of the button might be debatable, I didn't know how to call it, you might have better ideas than I do.

I didn't do any browser detection either since that would make this patch a bit more complex, I'm not sure it's worth it since it doesn't break other browsers.

@alexisju
Copy link

Nice, I like that :)

Its working but i have some suggestions:
-the script may not open the sidebar on the install;
-when a link is shared, the popup may close (and not stay opened with shaarli's homepage);
-another detail about the favicon : the script load the default shaarli favicon and not the favicon used by the current template (but maybe this can be fixed by the template's maintener if they use a specific favicon).

@Marsup
Copy link
Author

Marsup commented May 12, 2015

I don't think I have a say in whether or not the sidebar shows, the social API is mostly configuration.

I didn't know about custom favicons, there's no evidence of that in the code.
I'll look into making the popup close.

@Marsup
Copy link
Author

Marsup commented May 12, 2015

I'll look into making the popup close.

This part is done. Is there anywhere to look for custom favicons ?

@Marsup
Copy link
Author

Marsup commented May 12, 2015

After a discussion with @alexisju, no more sidebar (it's probably useless), and an experiment at hiding the header and footer for that popup. I personally like it.

@alexisju
Copy link

works well!

@Marsup
Copy link
Author

Marsup commented May 13, 2015

Something to mention is that commenting the footer removed the part where the delete confirmation happened. The fact is that if I leave that popup on, it steals the focus from the share popup and clicking yes or no doesn't make a difference, the delete won't happen. So if we want to keep that feature in that popup, it has to be a pure html/js confirmation.

@Aldarone
Copy link

You missed a few spot for closing the bookmarklet in index.php : Line 1570 and Line 1589

You can checkout loginform.phtml from my PR #216 It's a bit nicer when the user is not logged in yet.

And I would use {$shaarlititle} instead of Shaarli in the social api manifest, it will help the users to differentiate their Shaarlis if they have more than one.

@Marsup
Copy link
Author

Marsup commented May 15, 2015

Should be good now. Why did you add a few contentid to the templates ?

@Aldarone
Copy link

@alexisju
Copy link

Ready to merge (?)

@nodiscc nodiscc merged commit d33c5d4 into shaarli:master May 22, 2015
@nodiscc
Copy link
Member

nodiscc commented May 22, 2015

Works fine, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants