Convert test suite to run headless

[justin808]

Summary

• Registered the headless Chrome driver to prevent browser windows from flashing during test runs
• Tests were already configured to use selenium_chrome_headless but the driver wasn't being registered

Changes

• Added DriverRegistration.register_selenium_chrome_headless call in rails_helper.rb to properly initialize the headless driver
• The headless driver uses Chrome with --headless, --disable-gpu, --no-sandbox, and --disable-dev-shm-usage flags

Test plan

• Run bundle exec rspec spec/rescript/rescript_spec.rb and verify no browser window appears
• Verify tests still pass with headless configuration

🤖 Generated with Claude Code

---

This change is 

Summary by CodeRabbit

• Tests
  • Configured headless browser for UI/system tests to improve speed, reliability, and CI compatibility. Reduces flakiness, standardizes environments, lowers resource usage, and enables running suites without opening windows. No user-facing impact; development workflow becomes smoother and better suited for parallel runs, improves local setup consistency across teams, and reduces intermittent failures.

[github-actions]

🚀 Quick Review App Commands

Welcome! Here are the commands you can use in this PR:

/deploy-review-app

Deploy your PR branch for testing

/delete-review-app

Remove the review app when done

/help

Show detailed instructions, environment setup, and configuration options.

---

[coderabbitai]

Warning

Rate limit exceeded

@justin808 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 6 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 262e952 and b3a2a90.

📒 Files selected for processing (1)

• spec/rails_helper.rb (1 hunks)

Walkthrough

The test setup in spec/rails_helper.rb now registers a Selenium Chrome headless driver by invoking DriverRegistration.register_selenium_chrome_headless within RSpec.configure, positioned after asset compilation configuration and before fixture path setup.

Changes

Cohort / File(s)	Summary
RSpec test driver setup spec/rails_helper.rb	Add call to DriverRegistration.register_selenium_chrome_headless inside RSpec.configure to register headless Chrome driver during test initialization.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant RSpec as RSpec.configure
    participant DriverReg as DriverRegistration
    participant Capybara as Capybara (runtime)

    Note over RSpec: Test environment initialization
    RSpec->>DriverReg: register_selenium_chrome_headless()
    activate DriverReg
    DriverReg-->>RSpec: Headless Chrome driver registered
    deactivate DriverReg

    Note over Capybara: During feature/system specs
    Capybara->>Capybara: Use registered headless Chrome driver

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

I twitch my whiskers at the night,
Headless Chrome takes silent flight—
In specs we dart, no window shown,
A stealthy hop through pages flown.
Green checks sprout like garden dew;
I thump, “All tests!” and nibble, too.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title “Convert test suite to run headless” succinctly and accurately conveys the primary change of registering and configuring the headless Chrome driver for the test suite without extraneous details or vague terminology. It focuses on the main objective of the pull request—enabling headless test execution—and is clear and specific enough for a reviewer to understand the intent at a glance.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[claude]

Code Review for PR #658: Convert test suite to run headless

Thank you for this PR! I've reviewed the changes and here's my feedback:

✅ Overall Assessment

This is a clean, focused change that properly registers the headless Chrome driver. The implementation follows Rails and RSpec best practices.

Code Quality & Best Practices

• ✅ The placement of the driver registration call is appropriate within the RSpec configuration block
• ✅ Good use of the existing DriverRegistration module pattern
• ✅ The change is minimal and focused on a single responsibility

Potential Issues

• ⚠️ Minor concern: The driver registration happens inside the RSpec.configure block (line 47), but Capybara's default and JavaScript drivers are set later (lines 72-73). While this works because the driver is registered before it's used, for better clarity and maintainability, consider moving the registration closer to where the drivers are configured:

# Around lines 71-73
DriverRegistration.register_selenium_chrome_headless
Capybara.default_driver = :selenium_chrome_headless
Capybara.javascript_driver = :selenium_chrome_headless

Performance Considerations

• ✅ Headless mode will improve CI/CD performance by eliminating browser UI overhead
• ✅ The headless Chrome options (--disable-gpu, --no-sandbox, --disable-dev-shm-usage) are appropriate for containerized environments

Security Concerns

• ✅ No security issues identified
• The --no-sandbox flag is acceptable in testing environments

Test Coverage

• ✅ The test plan verifies the headless behavior works correctly
• ✅ Existing tests (like spec/rescript/rescript_spec.rb) will benefit from this change

Suggestion for Improvement

Consider adding a comment explaining why the registration is necessary, as it might not be immediately obvious to future developers:

# Register the headless Chrome driver before Capybara uses it
# This prevents browser windows from opening during test runs
DriverRegistration.register_selenium_chrome_headless

Overall, this is a solid improvement that will enhance the developer experience by preventing browser windows from flashing during test runs. The implementation is correct and follows established patterns in the codebase.

Approved ✅

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 707eee8 and 262e952.

📒 Files selected for processing (1)

• spec/rails_helper.rb (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

spec/rails_helper.rb (1)

spec/support/driver_registration.rb (1)

• register_selenium_chrome_headless (28-41)

🪛 RuboCop (1.80.2)

spec/rails_helper.rb

[convention] 45-45: Trailing whitespace detected.

(Layout/TrailingWhitespace)

🪛 GitHub Actions: Lint CI

spec/rails_helper.rb

[error] 45-45: RuboCop: Layout/TrailingWhitespace: Trailing whitespace detected. Command 'rubocop -S -D .' failed. Run 'bundle exec rubocop -S -D .' to fix.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: claude-review
• GitHub Check: test (22.x, 3.3.4)

[github-actions]

✅ Review app for PR #658 was successfully deleted

View Completed Delete Logs

Control Plane Organization

[claude]

Code Review for PR #658: Convert test suite to run headless

✅ Overall Assessment

This is a clean, focused change that properly enables headless Chrome for the test suite. The implementation is correct and follows established patterns.

Code Quality & Best Practices ✅

• The change is minimal and focused on a single purpose
• Follows the existing module pattern in DriverRegistration
• Properly uses the registration guard pattern with @selenium_headless_registered to prevent duplicate registrations
• Chrome options are correctly configured with industry-standard headless flags

Potential Issues ⚠️

• Missing verification: The PR doesn't verify that DriverRegistration module is actually loaded before calling it. However, this appears to be handled by the Rails autoloading mechanism and the existing test setup.
• Driver naming inconsistency: The registration method uses @selenium_headless_registered but should ideally use @selenium_chrome_headless_registered to match the driver name pattern used in other registration methods.

Performance Considerations 🚀

• Positive impact: Headless mode significantly improves test execution speed
• The --disable-dev-shm-usage flag prevents shared memory issues in containerized environments
• --no-sandbox and --disable-gpu flags optimize for CI environments

Security Considerations 🔒

• The --no-sandbox flag disables Chrome's sandbox, which is acceptable for testing environments but should never be used in production
• All flags are appropriate for a test-only context

Test Coverage ✅

• The change itself doesn't require additional tests as it's test infrastructure
• Existing test suite validates that the headless configuration works correctly
• The PR author has verified tests pass with the headless configuration

Suggestions for Improvement

1. Consider renaming the instance variable from @selenium_headless_registered to @selenium_chrome_headless_registered for consistency with other driver registration methods
2. Consider adding a comment explaining why each Chrome flag is necessary for future maintainers

Conclusion

This is a well-executed change that properly configures headless Chrome for the test suite. The implementation is sound and will improve the developer experience by preventing browser windows from flashing during test runs. The PR is ready to merge.

Great work! 👍