Skip to content

Update Ruby version from 3.3.4 to 3.4.3 #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −18
Open

Update Ruby version from 3.3.4 to 3.4.3 #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.3.4
3.4.3
7 changes: 1 addition & 6 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
source "https://rubygems.org"
git_source(:github) { |repo| "https://github.com/#{repo}.git" }

ruby "3.3.4"
ruby "3.4.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Update CI Ruby runtime to 3.4.3 before merging.

Bundler now requires Ruby 3.4.3, yet the GitHub Actions job still installs 3.3.4 (see failing RSpec CI log). Until the workflow is updated to install Ruby 3.4.3 (e.g., via ruby-version: 3.4.3 in actions/setup-ruby), every pipeline run will keep failing. Please align the CI runtime with this requirement.

🤖 Prompt for AI Agents 
In Gemfile at line 6, ruby "3.4.3" is specified but the GitHub Actions CI still
installs Ruby 3.3.4 causing RSpec failures; update the workflow(s) that install
Ruby (e.g., actions/setup-ruby steps) to use ruby-version: 3.4.3 (or set the
matrix/version variables accordingly) so the CI runtime matches the Gemfile
requirement and bundles run on Ruby 3.4.3.


gem "react_on_rails", "16.1.1"
gem "shakapacker", "9.0.0.beta.8"
Expand Down Expand Up @@ -45,11 +45,6 @@ gem "autoprefixer-rails"

gem "awesome_print"

# Needed until Ruby 3.3.4 is released https://github.com/ruby/ruby/pull/11006
# Related issue: https://github.com/ruby/net-pop/issues/26
# TODO: When Ruby 3.3.4 is released, upgrade Ruby and remove this line
gem "net-pop", github: "ruby/net-pop"

gem "redcarpet"

# jquery as the JavaScript library has been moved under /client and managed by npm.
Expand Down
14 changes: 3 additions & 11 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
GIT
remote: https://github.com/ruby/net-pop.git
revision: e8d0afe2773b9eb6a23c39e9e437f6fc0fc7c733
specs:
net-pop (0.1.2)
net-protocol

GEM
remote: https://rubygems.org/
specs:
Expand Down Expand Up @@ -148,8 +141,6 @@ GEM
factory_bot (~> 6.4)
railties (>= 5.0.0)
ffi (1.17.0)
ffi (1.17.0-arm64-darwin)
ffi (1.17.0-x86_64-linux-gnu)
foreman (0.88.1)
generator_spec (0.10.0)
activesupport (>= 3.0.0)
Expand Down Expand Up @@ -195,6 +186,8 @@ GEM
net-imap (0.5.10)
date
net-protocol
net-pop (0.1.2)
net-protocol
net-protocol (0.2.2)
timeout
net-smtp (0.5.1)
Expand Down Expand Up @@ -474,7 +467,6 @@ DEPENDENCIES
jbuilder
launchy
listen
net-pop!
pg
pry
pry-byebug
Expand Down Expand Up @@ -508,7 +500,7 @@ DEPENDENCIES
web-console

RUBY VERSION
ruby 3.3.4p94
ruby 3.4.3p32

BUNDLED WITH
2.4.17
Loading