Update contributing.md and move gem release info to own file #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/contributing.md
Outdated
There was a problem hiding this comment.
Let's move the release part to a separate file in the docs directory. I'm the only one that's going to be doing releases, so this does not apply to anybody else, on the release part.
There was a problem hiding this comment.
OTOH -- good to have docs on how I updated the https://github.com/shakacode/react-webpack-rails-tutorial/ to point to a branch or local version for testing.
There was a problem hiding this comment.
We might want to note that if you change the gem code, you need to restart the dummy app to see your changes.
Rails does not auto-reload gems.
|
A few comments to address. |
robwise
force-pushed
the
fix-typo-contributing-doc
branch
from
c0630c6 to
9b6bcb6
Compare
robwise
changed the title
robwise
force-pushed
the
fix-typo-contributing-doc
branch
from
9b6bcb6 to
d1d8296
Compare
justin808
added a commit
that referenced
this pull request
Nov 26, 2015
Update contributing.md and move gem release info to own file
AbanoubGhadban
pushed a commit
that referenced
this pull request
Sep 25, 2025
Assets always copied every time a new bundle is sent This way we don't need any shell hacks to make sure assets go over to the renderer instance. Also, support an array of assets to copy.
AbanoubGhadban
pushed a commit
that referenced
this pull request
Sep 26, 2025
Assets always copied every time a new bundle is sent This way we don't need any shell hacks to make sure assets go over to the renderer instance. Also, support an array of assets to copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.