Don't set NODE_ENV in assets.rake #1356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting NODE_ENV here interferes with Rails'/webpacker's control of this variable, particularly in production. In particular, this means that compiling assets in production using `bundle exec rails assets:precompile` uses the development webpacker configuration rather than the production one.
|
@Judahmeek I think this PR is OK. Can you check and we can release a 12.0.5 if you say it's good. |
|
@justin808 LGTM. Should we change line 8 to default to "production" since webpack will default to production if a mode isn't set? |
No. That's for rails_env...and it's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting NODE_ENV here interferes with Rails'/webpacker's control of this
variable, particularly in production. In particular, this means that
compiling assets in production using
bundle exec rails assets:precompileuses the development webpackerconfiguration rather than the production one.
This change is