Many doc updates #1367
Many doc updates #1367
Conversation
1. Renamed basics to guides 2. Moved Rails/Webpacker React Integration Options to be inside of "guides"
There was a problem hiding this comment.
Reviewed 30 of 30 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @justin808)
README.md, line 54 at r2 (raw file):
Feel free to contact Justin Gordon, [justin@shakacode.com](mailto:justin@shakacode.com), maintainer of React on Rails, for more information. [Click to join **React + Rails Slack**](https://reactrails.slack.com/join/shared_invite/enQtNjY3NTczMjczNzYxLTlmYjdiZmY3MTVlMzU2YWE0OWM0MzNiZDI0MzdkZGFiZTFkYTFkOGVjODBmOWEyYWQ3MzA2NGE1YWJjNmVlMGE).
Are we linking to the ReactRails slack somewhere else?
Judahmeek
force-pushed
the
justin808/doc-updates
branch
from
8f31ef0 to
0b34290
Compare
There was a problem hiding this comment.
https://chrome.google.com/webstore/detail/link-checker/aibjbgmpmnidnmagaefhmcjhadpffaoi to find the bad links.
README.md
Outdated
| 1. [Reason ML Support](https://github.com/shakacode/reason-react-on-rails-example). | ||
|
|
||
| See [Rails/Webpacker React Integration Options](docs/guides/rails-webpacker-react-integration-options.md) for comparisons to other gems. | ||
| See [Rails/Webpacker React Integration Options](https://www.shakacode.com/react-on-rails/docs/guides/rails-webpacker-react-integration-options.md) for comparisons to other gems. |
There was a problem hiding this comment.
This sort of md link won't work.
There was a problem hiding this comment.
...and that's why relative links won't work right now.
There was a problem hiding this comment.
@Judahmeek did you check that any recent updates to the README and other docs got merged correctly into this PR?
I reverted your Status Hero image update during the rebase & forgot to check whether that was the correct choice so I'm glad you asked. My latest commit corrects this & the shakacode I didn't see any other changes that weren't properly merged. |
"guides"
This change is