Phase 3: Prepare core package for workspace structure

.github/workflows/lint-js-and-ruby.yml

@@ -45,7 +45,7 @@ jobs:
           yarn install --no-progress --no-emoji --frozen-lockfile
           sudo yarn global add yalc
       - name: yalc publish for react-on-rails
-        run: yalc publish
+        run: cd packages/react-on-rails && yalc publish
       - name: yalc add react-on-rails
         run: cd spec/dummy && yalc add react-on-rails
       - name: Install Node modules with Yarn for dummy app
@@ -81,12 +81,12 @@ jobs:
       - name: Type-check TypeScript
         run: yarn run type-check
       - name: Pack for attw and publint
-        run: yarn pack -f react-on-rails.tgz
+        run: cd packages/react-on-rails && yarn pack -f react-on-rails.tgz
       - name: Lint package types
         # our package is ESM-only
-        run: yarn run attw react-on-rails.tgz --profile esm-only
+        run: yarn run attw packages/react-on-rails/react-on-rails.tgz --profile esm-only
       - name: Lint package publishing
-        run: yarn run publint --strict react-on-rails.tgz
+        run: yarn run publint --strict packages/react-on-rails/react-on-rails.tgz
       # We only download and run Actionlint if there is any difference in GitHub Action workflows
       # https://github.com/rhysd/actionlint/blob/main/docs/usage.md#on-github-actions
       - name: Check GitHub Action changes

.github/workflows/main.yml

@@ -61,7 +61,7 @@ jobs:
           yarn install --no-progress --no-emoji ${{ matrix.dependency-level == 'latest' && '--frozen-lockfile' || '' }}
           sudo yarn global add yalc
       - name: yalc publish for react-on-rails
-        run: yalc publish
+        run: cd packages/react-on-rails && yalc publish
       - name: yalc add react-on-rails
         run: cd spec/dummy && yalc add react-on-rails
       - name: Install Node modules with Yarn for dummy app
@@ -159,7 +159,7 @@ jobs:
           yarn install --no-progress --no-emoji ${{ matrix.dependency-level == 'latest' && '--frozen-lockfile' || '' }}
           sudo yarn global add yalc
       - name: yalc publish for react-on-rails
-        run: yalc publish
+        run: cd packages/react-on-rails && yalc publish
       - name: yalc add react-on-rails
         run: cd spec/dummy && yalc add react-on-rails
       - name: Install Node modules with Yarn for dummy app

.gitignore

@@ -20,7 +20,7 @@ tmp/
 
 node_modules
 
-/node_package/lib
+/packages/*/lib
 
 yarn-debug.*
 yarn-error.*

.prettierignore

@@ -6,7 +6,7 @@ tmp/
 coverage/
 **/app/assets/webpack/
 gen-examples/examples/*
-node_package/lib/*
+packages/*/lib/*
 spec/react_on_rails/dummy-for-generators/app/javascript/bundles/HelloWorld/*
 bundle/
 spec/dummy/lib/bs/**

CHANGELOG.md

@@ -71,7 +71,7 @@ Changes since the last non-beta release.
 
 #### Pro License Features
 
-- **Core/Pro separation**: Moved Pro features into dedicated `lib/react_on_rails/pro/` and `node_package/src/pro/` directories with clear licensing boundaries [PR 1791](https://github.com/shakacode/react_on_rails/pull/1791) by [AbanoubGhadban](https://github.com/AbanoubGhadban)
+- **Core/Pro separation**: Moved Pro features into dedicated `lib/react_on_rails/pro/` and `node_package/src/pro/` directories with clear licensing boundaries (now located at `packages/react-on-rails/src/pro/`) [PR 1791](https://github.com/shakacode/react_on_rails/pull/1791) by [AbanoubGhadban](https://github.com/AbanoubGhadban)
 - **Runtime license validation**: Implemented Pro license gating with graceful fallback to core functionality when Pro license unavailable [PR 1791](https://github.com/shakacode/react_on_rails/pull/1791) by [AbanoubGhadban](https://github.com/AbanoubGhadban)
 - **Enhanced immediate hydration**: Improved immediate hydration functionality with Pro license validation and warning badges [PR 1791](https://github.com/shakacode/react_on_rails/pull/1791) by [AbanoubGhadban](https://github.com/AbanoubGhadban)
 - **License documentation**: Added NOTICE files in Pro directories referencing canonical `REACT-ON-RAILS-PRO-LICENSE.md` [PR 1791](https://github.com/shakacode/react_on_rails/pull/1791) by [AbanoubGhadban](https://github.com/AbanoubGhadban)
@@ -400,6 +400,8 @@ _Major bump because dropping support for Ruby 2.7 and deprecated `webpackConfigL
    @ ./client/app/packs/client-bundle.js 5:0-42 32:0-23 35:0-21 59:0-26
   ```
 
+  _Note: The `node_package/lib/` path in these error examples is now `packages/react-on-rails/lib/` in the current structure._
+
   It can be safely [suppressed](https://webpack.js.org/configuration/other-options/#ignorewarnings) in your Webpack configuration.
 
 ### [13.0.2] - 2022-03-09

CLAUDE.md

@@ -36,7 +36,7 @@ Git hooks will automatically run linting on **all changed files (staged + unstag
 - **Code Formatting**:
   - Format code with Prettier: `rake autofix`
   - Check formatting without fixing: `yarn start format.listDifferent`
-- **Build**: `yarn run build` (compiles TypeScript to JavaScript in node_package/lib)
+- **Build**: `yarn run build` (compiles TypeScript to JavaScript in packages/react-on-rails/lib)
 - **Type checking**: `yarn run type-check`
 - **⚠️ MANDATORY BEFORE GIT PUSH**: `bundle exec rubocop` and fix ALL violations + ensure trailing newlines
 - Never run `npm` commands, only equivalent Yarn Classic ones
@@ -86,7 +86,7 @@ Git hooks will automatically run linting on **all changed files (staged + unstag
 This project maintains both a Ruby gem and an NPM package:
 
 - **Ruby gem**: Located in `lib/`, provides Rails integration and server-side rendering
-- **NPM package**: Located in `node_package/src/`, provides client-side React integration
+- **NPM package**: Located in `packages/react-on-rails/src/`, provides client-side React integration
 
 ### Core Components
 
@@ -98,7 +98,7 @@ This project maintains both a Ruby gem and an NPM package:
 - **`engine.rb`**: Rails engine integration
 - **Generators**: Located in `lib/generators/react_on_rails/`
 
-#### JavaScript/TypeScript Side (`node_package/src/`)
+#### JavaScript/TypeScript Side (`packages/react-on-rails/src/`)
 
 - **`ReactOnRails.ts`**: Main entry point for client-side functionality
 - **`serverRenderReactComponent.ts`**: Server-side rendering logic
@@ -108,7 +108,7 @@ This project maintains both a Ruby gem and an NPM package:
 ### Build System
 
 - **Ruby**: Standard gemspec-based build
-- **JavaScript**: TypeScript compilation to `node_package/lib/`
+- **JavaScript**: TypeScript compilation to `packages/react-on-rails/lib/`
 - **Testing**: Jest for JS, RSpec for Ruby
 - **Linting**: ESLint for JS/TS, RuboCop for Ruby
 
@@ -130,6 +130,6 @@ This project maintains both a Ruby gem and an NPM package:
 
 Exclude these directories to prevent IDE slowdowns:
 
-- `/coverage`, `/tmp`, `/gen-examples`, `/node_package/lib`
+- `/coverage`, `/tmp`, `/gen-examples`, `/packages/react-on-rails/lib`
 - `/node_modules`, `/spec/dummy/node_modules`, `/spec/dummy/tmp`
 - `/spec/dummy/app/assets/webpack`, `/spec/dummy/log`

CODING_AGENTS.md

@@ -287,7 +287,7 @@ Use `gh pr create` with:
 When analyzing codebases, ignore these directories to avoid confusion:
 
 - `/coverage`, `/tmp`, `/gen-examples`
-- `/node_package/lib`, `/node_modules`
+- `/packages/react-on-rails/lib`, `/node_modules`
 - `/spec/dummy/app/assets/webpack`
 - `/spec/dummy/log`, `/spec/dummy/node_modules`, `/spec/dummy/tmp`
 - `/spec/react_on_rails/dummy-for-generators`

CONTRIBUTING.md

@@ -40,7 +40,7 @@ It's critical to configure your IDE/editor to ignore certain directories. Otherw
 - /coverage
 - /tmp
 - /gen-examples
-- /node_package/lib
+- /packages/react-on-rails/lib
 - /node_modules
 - /spec/dummy/app/assets/webpack
 - /spec/dummy/log
@@ -121,7 +121,7 @@ Don't forget you may need to run yarn after adding packages with yalc to install
 
 #### Example: Testing NPM changes with the dummy app
 
-1. Add `console.log('Hello!')` to [clientStartup.ts, function render](https://github.com/shakacode/react_on_rails/blob/master/node_package/src/clientStartup.ts in `/node_package/src/clientStartup.js` to confirm we're getting an update to the node package client side. Do the same for function `serverRenderReactComponent` in `/node_package/src/serverRenderReactComponent.ts`.
+1. Add `console.log('Hello!')` to [clientStartup.ts, function render](https://github.com/shakacode/react_on_rails/blob/master/packages/react-on-rails/src/clientStartup.ts) in `/packages/react-on-rails/src/clientStartup.ts` to confirm we're getting an update to the node package client side. Do the same for function `serverRenderReactComponent` in [/packages/react-on-rails/src/serverRenderReactComponent.ts](https://github.com/shakacode/react_on_rails/blob/master/packages/react-on-rails/src/serverRenderReactComponent.ts).
 2. Refresh the browser if the server is already running or start the server using `foreman start` from `react_on_rails/spec/dummy` and navigate to `http://localhost:5000/`. You will now see the `Hello!` message printed in the browser's console. If you did not see that message, then review the steps above for the workflow of making changes and pushing them via yalc.
 
 # Development Setup for Gem and Node Package Contributors
@@ -134,7 +134,7 @@ After checking out the repo, making sure you have Ruby and Node version managers
 
 ### Local Node Package
 
-Note, the example and dummy apps will use your local `node_packages` folder as the `react-on-rails` node package. This will also be done automatically for you via the `rake examples:gen_all` rake task.
+Note, the example and dummy apps will use your local `packages/react-on-rails` folder as the `react-on-rails` node package. This will also be done automatically for you via the `rake examples:gen_all` rake task.
 
 _Side note: It's critical to use the alias section of the Webpack config to avoid a double inclusion error. This has already been done for you in the example and dummy apps, but for reference:_
 

LICENSE.md

@@ -12,17 +12,17 @@ This repository contains code under two different licenses:
 The following directories and all their contents are licensed under the **MIT License** (see full text below):
 
 - `lib/react_on_rails/` (excluding `lib/react_on_rails/pro/`)
-- `node_package/src/` (excluding `node_package/src/pro/`)
-- `node_package/lib/` (excluding `node_package/lib/pro/`)
+- `packages/react-on-rails/` (excluding `packages/react-on-rails/src/pro/`)
+- `packages/react-on-rails/lib/` (excluding `packages/react-on-rails/lib/pro/`)
 - All other directories in this repository not explicitly listed as Pro-licensed
 
 ### Pro Licensed Code
 
 The following directories and all their contents are licensed under the **React on Rails Pro License**:
 
 - `lib/react_on_rails/pro/`
-- `node_package/src/pro/`
-- `node_package/lib/pro/`
+- `packages/react-on-rails/src/pro/`
+- `packages/react-on-rails/lib/pro/`
 - `react_on_rails_pro/` (entire directory)
 
 See [REACT-ON-RAILS-PRO-LICENSE.md](./REACT-ON-RAILS-PRO-LICENSE.md) for complete Pro license terms.

docs/DIRECTORY_LICENSING.md

@@ -48,10 +48,10 @@ After the monorepo merger, the unified repository will have clear directory-base
 
 ```
 react_on_rails/ (monorepo root)
-├── lib/react_on_rails/           # Core Ruby code
-├── packages/react-on-rails/      # Core NPM package
-├── spec/ruby/react_on_rails/     # Core Ruby tests
-├── spec/packages/react-on-rails/ # Core JS tests
+├── lib/react_on_rails/           # Core Ruby code (including specs)
+├── packages/react-on-rails/      # Core NPM package (including tests)
+├── spec/                         # Monorepo-level integration tests
+│   └── dummy/                    # Rails dummy app for testing
 ├── docs/                         # Shared documentation
 ├── tools/                        # Shared development tools
 ├── .github/                      # Unified GitHub workflows
@@ -62,12 +62,9 @@ react_on_rails/ (monorepo root)
 
 ```
 react_on_rails/ (monorepo root)
-├── lib/react_on_rails_pro/       # Pro Ruby code
-├── packages/react-on-rails-pro/  # Pro NPM package
-├── packages/react-on-rails-pro-node-renderer/  # Pro Node renderer
-├── spec/ruby/react_on_rails_pro/ # Pro Ruby tests
-├── spec/packages/react-on-rails-pro/  # Pro JS tests
-└── spec/packages/react-on-rails-pro-node-renderer/  # Pro Node renderer tests
+├── lib/react_on_rails_pro/       # Pro Ruby code (including specs)
+├── packages/react-on-rails-pro/  # Pro NPM package (including tests)
+└── packages/react-on-rails-pro-node-renderer/  # Pro Node renderer (including tests)
 ```
 
 ## License Compliance Rules