Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests [WIP] #45

Closed
wants to merge 1 commit into from
Closed

Integration tests [WIP] #45

wants to merge 1 commit into from

Conversation

mapreal19
Copy link
Member

No description provided.

@mapreal19 mapreal19 changed the title Integration tests Integration tests [WIP] Sep 29, 2015
@mapreal19
Copy link
Member Author

@dylangrafmyre could you help me with the setup? I've tried what is on the tutorial, but I'm not sure if I'm missing something

@dylangrafmyre
Copy link
Contributor

@mapreal19 can you please make a branch under this repo with these changes? That way I can pull down the branch to test the issues you are experiencing. You are a collaborator on the repo. Thanks!

Are the test failing for you locally or just only on CI? Or both?

@mapreal19
Copy link
Member Author

@dylangrafmyre is failing only on CI.

Also for pulling you could install git extras and just do git pr 45 ;)

@dylangrafmyre
Copy link
Contributor

@mapreal19 Here is the fix:
https://github.com/shakacode/react_on_rails/blob/pr/45/.travis.yml

You need to generate the webpack bundles for the test. Also the test is not using the Selenium driver, but I am sure you will be using js: true within the other feature tests that will utilize the js driver.

@mapreal19
Copy link
Member Author

thanks @dylangrafmyre! I'll close this and then we can continue to work on that branch

@mapreal19 mapreal19 closed this Sep 30, 2015
@shakacode shakacode mentioned this pull request Oct 2, 2015
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants