Skip to content

Get Diagnostics Data API #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Get Diagnostics Data API #27

wants to merge 1 commit into from

Conversation

dhlaluku
Copy link

@dhlaluku dhlaluku commented Nov 29, 2018 •
edited
Loading

Get Diagnostics Data from system VMs
Docs; https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Get+Diagnostics+Data+API

Description

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

@dhlaluku dhlaluku force-pushed the retrieve-diagnostics-data branch from c06d256 to fa5379a Compare December 4, 2018 17:41
@dhlaluku dhlaluku changed the base branch from master to 4.11 December 4, 2018 17:42
@dhlaluku dhlaluku changed the base branch from 4.11 to master December 4, 2018 17:43
@dhlaluku dhlaluku changed the base branch from master to 4.11 December 4, 2018 17:44
@dhlaluku dhlaluku changed the base branch from 4.11 to master December 4, 2018 17:44
@dhlaluku dhlaluku requested a review from nvazquez December 4, 2018 18:41
@dhlaluku dhlaluku self-assigned this Dec 4, 2018
@dhlaluku dhlaluku added this to the 4.12.0 milestone Dec 4, 2018
@dhlaluku dhlaluku force-pushed the retrieve-diagnostics-data branch from 423d1c6 to 18b55a0 Compare December 5, 2018 06:12
@borisstoyanov
Copy link
Member

@dhlaluku this has been passed to me for testing but the title still says "work in progress"?

@dhlaluku
Copy link
Author

@borisstoyanov let me fix the merge conflict and remove the WIP from the label

@dhlaluku dhlaluku force-pushed the retrieve-diagnostics-data branch from bbbe373 to fda69b2 Compare January 15, 2019 07:23
@dhlaluku dhlaluku changed the title [WIP] Get Diagnostics Data API (for review) Get Diagnostics Data API Jan 15, 2019
@dhlaluku dhlaluku changed the base branch from master to 4.11 January 15, 2019 07:26
@dhlaluku dhlaluku changed the base branch from 4.11 to master January 15, 2019 07:27
@dhlaluku dhlaluku force-pushed the retrieve-diagnostics-data branch from fda69b2 to ff46636 Compare February 25, 2019 08:07
DaanHoogland
DaanHoogland reviewed Mar 1, 2019
View reviewed changes
Copy link
Member

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions and comments

core/src/main/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
_eachTimeout = Duration.standardSeconds(cmd.getTimeout());
final ExecutionResult result = _vrDeployer.executeInVR(cmd.getRouterAccessIp(), VRScripts.RETRIEVE_DIAGNOSTICS, fileList, _eachTimeout);
if (result.isSuccess()){
return new PrepareFilesAnswer(cmd, true, result.getDetails());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no validation of result.details?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No validation required here, success/fail is handled in the service layer class "DiagnosticsServiceImpl"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for validation here, script/command execution should be propagated back to service layer using command-answer pattern

...sors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java Outdated
* @param fileName filepath inside system vm, /root/diagnostics_files_xxxx.tar
*/
protected void cleanUpFileInVm(String vmIP, String fileName) {
final String PERM_KEY = "/root/.ssh/id_rsa.cloud";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, extracted Zip file in system vm file cleanup to Network element command which makes it hypervisor agnostic

server/src/main/java/com/cloud/server/StatsCollector.java
@@ -1364,6 +1364,14 @@ public boolean imageStoreHasEnoughCapacity(DataStore imageStore) {
return false;
}

public boolean imageStoreHasEnoughCapacity(DataStore imageStore, Double storeCapThreshold) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javadoc to explain how storeCapThreshold is used would be nice

dhlaluku pushed a commit that referenced this pull request Mar 12, 2019
Merge pull request #27 from shapeblue/dingane/fro210
1175081 
BT-HF66 Publish disk resize event in cloud_usage
@dhlaluku dhlaluku force-pushed the retrieve-diagnostics-data branch from 679e170 to fbbee31 Compare March 19, 2019 15:28
* Complete API implementation
0b247be 
* Complete UI integration
* Complete marvin test
* Complete Secondary storage GC background task
@dhlaluku dhlaluku force-pushed the retrieve-diagnostics-data branch from fbbee31 to 0b247be Compare March 21, 2019 10:34
shwstppr added a commit that referenced this pull request Nov 3, 2020
@shwstppr
Volume migration fix wrt #22 (#27)
03d9cb5 
* fix worker vm

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* remove unwanted logs

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
rohityadavcloud pushed a commit that referenced this pull request Jan 20, 2021
@rohityadavcloud
dashboard improvements (#27)
f71ed85 
* Add new grid values new classes to replace inline stlyes with it

* Fix navigation scroll behavior

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
shwstppr added a commit that referenced this pull request Aug 16, 2021
@shwstppr
Volume migration fix wrt #22 (#27)
e7030a7 
* fix worker vm

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* remove unwanted logs

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Hi @dependabot[bot], your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland left review comments

@nvazquez nvazquez nvazquez left review comments

@anuragaw anuragaw Awaiting requested review from anuragaw

@borisstoyanov borisstoyanov Awaiting requested review from borisstoyanov

Assignees

@dhlaluku dhlaluku

Labels
new feature status:has-conflicts
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dhlaluku @borisstoyanov @DaanHoogland @nvazquez @rohityadavcloud