Make the liveliness periodic more robust #199
Conversation
The previous SSH test was prone to sporadic failures with a failure rate above 10% for the amphora driver in vh-mecha-central. The HTTP test has been reliable so far in testing. The liveliness periodic invokes server.sh with `-u centos`, which both supplied the username to use when logging in via SSH and enabled the test. We no longer require a login username for the test so we add a new option `-l` which enables the test without taking an option. We retain the `-u` option for compatibility with the periodic. It can be removed after we have updated the periodic.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| lb_ids+=("${lb_id}") | ||
|
|
||
| lb_listener_id="$(openstack loadbalancer listener create --wait --name "$name" -f value -c id --protocol TCP --protocol-port 22 "$lb_id")" | ||
| lb_listener_id="$(openstack loadbalancer listener create --wait --name "$name" -f value -c id --protocol TCP --protocol-port 80 "$lb_id")" |
There was a problem hiding this comment.
since you changed the port, I guess we could remove the security group on line 84
but you can also leave it here for debug purpose, no strong opinion
There was a problem hiding this comment.
I did actually initially take this out along with the icmp one.. However I decided not to remove them because IIUC there are at least theoretically other users of this script?
I wonder if @pierreprinetti knows if these should stay or not.
There was a problem hiding this comment.
There are not afaik, and actually I believe we could lower complexity by removing options not relevant for the liveness check. And rename it accordingly
|
/lgtm |
Landing shiftstack/shiftstack-ci#199 and shiftstack/shiftstack-ci#200 means we no longer need any complications in the liveliness check relating to users or ssh keys.
Landing shiftstack/shiftstack-ci#199 and shiftstack/shiftstack-ci#200 means we no longer need any complications in the liveliness check relating to users or ssh keys.
4 participants
The previous SSH test was prone to sporadic failures with a failure rate above 10% for the amphora driver in vh-mecha-central. The HTTP test has been reliable so far in testing.
The liveliness periodic invokes server.sh with
-u centos, which both supplied the username to use when logging in via SSH and enabled the test. We no longer require a login username for the test so we add a new option-lwhich enables the test without taking an option. We retain the-uoption for compatibility with the periodic. It can be removed after we have updated the periodic.