Make -k <keypair> optional #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to remove keypair generation from the periodic, as it's no longer required.
We don't want to suppress warnings with --silent, but we don't need the progress bar in the logs.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
mdbooth
added a commit
to shiftstack/release
that referenced
this pull request
Jan 16, 2023
Landing shiftstack/shiftstack-ci#199 and shiftstack/shiftstack-ci#200 means we no longer need any complications in the liveliness check relating to users or ssh keys.
openshift-merge-robot
pushed a commit
to openshift/release
that referenced
this pull request
Jan 17, 2023
Landing shiftstack/shiftstack-ci#199 and shiftstack/shiftstack-ci#200 means we no longer need any complications in the liveliness check relating to users or ssh keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to remove keypair generation from the periodic, as it's no longer required.
Also remove some curl noise from the logs.