fix: file leak in reading cgroups

smira · smira · commit 2f23fedeb725 · 2025-10-15T18:24:30.000+04:00
Ensure to close the file.
This bug is only in `main` I believe.

Signed-off-by: Andrey Smirnov &lt;andrey.smirnov@siderolabs.com&gt;
diff --git a/internal/pkg/cgroups/reader.go b/internal/pkg/cgroups/reader.go
@@ -17,6 +17,8 @@ func ReadCgroupfsProperty(node *Node, cgroupPath, property string) error {
 		return fmt.Errorf("error opening cgroupfs file %w", err)
 	}
 
+	defer f.Close() //nolint:errcheck
+
 	err = node.Parse(property, f)
 	if err != nil {
 		return fmt.Errorf("error parsing cgroupfs file %w", err)

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,8 @@ func ReadCgroupfsProperty(node *Node, cgroupPath, property string) error {`
`17`	`17`	`return fmt.Errorf("error opening cgroupfs file %w", err)`
`18`	`18`	`}`
`19`	`19`
	`20`	`+ defer f.Close() //nolint:errcheck`
	`21`	`+`
`20`	`22`	`err = node.Parse(property, f)`
`21`	`23`	`if err != nil {`
`22`	`24`	`return fmt.Errorf("error parsing cgroupfs file %w", err)`