feat: update dependencies

Many small changes, linting fixes, migration to moby/moby client
package.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>

Author: smira

Dockerfile

@@ -1,4 +1,4 @@
-# syntax = docker/dockerfile-upstream:1.19.0-labs
+# syntax = docker/dockerfile-upstream:1.20.0-labs
 
 # Meta args applied to stage base names.
 

Makefile

@@ -25,9 +25,9 @@ DEBUG_TOOLS_SOURCE := scratch
 EMBED_TARGET ?= embed
 
 TOOLS_PREFIX ?= ghcr.io/siderolabs/tools
-TOOLS ?= v1.12.0-alpha.0-18-g44932c0
+TOOLS ?= v1.12.0
 PKGS_PREFIX ?= ghcr.io/siderolabs
-PKGS ?= v1.12.0-alpha.0-52-g1768ccf
+PKGS ?= v1.12.0
 GENERATE_VEX_PREFIX ?= ghcr.io/siderolabs/generate-vex
 GENERATE_VEX ?= latest
 
@@ -104,9 +104,9 @@ KUBECTL_VERSION ?= v1.35.0-alpha.3
 # renovate: datasource=github-releases depName=kastenhq/kubestr
 KUBESTR_VERSION ?= v0.4.49
 # renovate: datasource=github-releases depName=helm/helm
-HELM_VERSION ?= v3.19.0
+HELM_VERSION ?= v4.0.0
 # renovate: datasource=github-releases depName=cilium/cilium-cli
-CILIUM_CLI_VERSION ?= v0.18.7
+CILIUM_CLI_VERSION ?= v0.18.8
 # renovate: datasource=github-releases depName=microsoft/secureboot_objects
 MICROSOFT_SECUREBOOT_RELEASE ?= v1.1.3
 

cmd/installer/pkg/install/install.go

@@ -142,7 +142,7 @@ func Install(ctx context.Context, p runtime.Platform, mode Mode, opts *Options)
 
 		var b runtime.Board
 
-		b, err := board.NewBoard(opts.Board)
+		b, err := board.NewBoard(opts.Board) //nolint:staticcheck
 		if err != nil {
 			return err
 		}
@@ -364,7 +364,7 @@ func (i *Installer) Install(ctx context.Context, mode Mode) (err error) {
 			if i.options.Board != constants.BoardNone {
 				var b runtime.Board
 
-				b, err = board.NewBoard(i.options.Board)
+				b, err = board.NewBoard(i.options.Board) //nolint:staticcheck
 				if err != nil {
 					return err
 				}
@@ -454,7 +454,7 @@ func (i *Installer) createPartitions(ctx context.Context, gptdev gpt.Device, mod
 	if i.options.Board != constants.BoardNone && !quirks.New(i.options.Version).SupportsOverlay() {
 		var b runtime.Board
 
-		b, err := board.NewBoard(i.options.Board)
+		b, err := board.NewBoard(i.options.Board) //nolint:staticcheck
 		if err != nil {
 			return nil, err
 		}

cmd/talosctl/cmd/mgmt/cluster/create/cmd_dev.go

@@ -9,6 +9,7 @@ import (
 	"fmt"
 	"runtime"
 	"slices"
+	"strings"
 
 	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
@@ -276,7 +277,8 @@ func getCreateCmd(cmdName string, hidden bool) *cobra.Command {
 					return err
 				}
 
-				disks := fmt.Sprintf("virtio:%d", legacyOps.clusterDiskSize)
+				var disks strings.Builder
+				disks.WriteString(fmt.Sprintf("virtio:%d", legacyOps.clusterDiskSize))
 
 				for i := range legacyOps.extraDisks {
 					driver := "ide"
@@ -290,12 +292,12 @@ func getCreateCmd(cmdName string, hidden bool) *cobra.Command {
 						driver = legacyOps.extraDisksDrivers[i]
 					}
 
-					disks += fmt.Sprintf(",%s:%d", driver, legacyOps.extraDiskSize)
+					disks.WriteString(fmt.Sprintf(",%s:%d", driver, legacyOps.extraDiskSize))
 				}
 
 				qOps.Disks = flags.Disks{}
 
-				if err := qOps.Disks.Set(disks); err != nil {
+				if err := qOps.Disks.Set(disks.String()); err != nil {
 					return err
 				}
 

cmd/talosctl/cmd/mgmt/cluster/create/cmd_qemu.go

@@ -6,6 +6,7 @@ package create
 
 import (
 	"context"
+	"strings"
 
 	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
@@ -46,19 +47,21 @@ func init() {
 		return qemu
 	}
 
-	cmdDescription := "Create a local QEMU based Talos cluster\n"
+	var cmdDescription strings.Builder
+	cmdDescription.WriteString("Create a local QEMU based Talos cluster\n")
+
+	cmdDescription.WriteString("Available presets:\n")
 
-	cmdDescription += "Available presets:\n"
 	for _, p := range preset.Presets {
-		cmdDescription += "  - " + p.Name() + ": " + p.Description() + "\n"
+		cmdDescription.WriteString("  - " + p.Name() + ": " + p.Description() + "\n")
 	}
 
-	cmdDescription += "\n"
-	cmdDescription += "Note: exactly one of 'iso', 'iso-secureboot', 'pxe' or 'disk-image' presets must be specified.\n"
+	cmdDescription.WriteString("\n")
+	cmdDescription.WriteString("Note: exactly one of 'iso', 'iso-secureboot', 'pxe' or 'disk-image' presets must be specified.\n")
 
 	createQemuCmd := &cobra.Command{
 		Use:   providers.QemuProviderName,
-		Short: cmdDescription,
+		Short: cmdDescription.String(),
 		Args:  cobra.NoArgs,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			return cli.WithContext(context.Background(), func(ctx context.Context) error {

cmd/talosctl/cmd/talos/cgroupsprinter/tree.go

@@ -29,13 +29,13 @@ const (
 //
 //nolint:gocyclo
 func PrintNode(name string, w io.Writer, schema *Schema, node, parent *cgroups.Node, level int, levelsEnded []int, lastNode, treeRoot bool) error {
-	var prefix string
+	var prefix strings.Builder
 
 	for i := range level {
 		if slices.Index(levelsEnded, i) != -1 {
-			prefix += strings.Repeat(" ", indentSize+1)
+			prefix.WriteString(strings.Repeat(" ", indentSize+1))
 		} else {
-			prefix += string(edgeTypeLink) + strings.Repeat(" ", indentSize)
+			prefix.WriteString(string(edgeTypeLink) + strings.Repeat(" ", indentSize))
 		}
 	}
 
@@ -62,7 +62,7 @@ func PrintNode(name string, w io.Writer, schema *Schema, node, parent *cgroups.N
 		return err
 	}
 
-	_, err = fmt.Fprintf(w, "%s%s%s\t%s\n", prefix, edge, name, rowData)
+	_, err = fmt.Fprintf(w, "%s%s%s\t%s\n", prefix.String(), edge, name, rowData)
 	if err != nil {
 		return err
 	}

cmd/talosctl/cmd/talos/pcap.go

@@ -174,7 +174,7 @@ func parseBPFInstructions(in string) ([]*machine.BPFInstruction, error) {
 
 	var result []*machine.BPFInstruction //nolint:prealloc
 
-	for _, line := range strings.Split(in, "\n") {
+	for line := range strings.SplitSeq(in, "\n") {
 		if line == "" {
 			continue
 		}