chore: deprecate interactive installer mode

Removes `interactive` from `talosctl apply-config --mode interactive`,
and deprecates related APIs.

Signed-off-by: Laura Brehm <laurabrehm@hey.com>

Author: laurazard

api/machine/machine.proto

@@ -64,7 +64,10 @@ service MachineService {
   // EtcdDowngradeCancel cancels etcd cluster downgrade that is in progress.
   // This method is available only on control plane nodes (which run etcd).
   rpc EtcdDowngradeCancel(google.protobuf.Empty) returns (EtcdDowngradeCancelResponse);
-  rpc GenerateConfiguration(GenerateConfigurationRequest) returns (GenerateConfigurationResponse);
+  rpc GenerateConfiguration(GenerateConfigurationRequest) returns (GenerateConfigurationResponse) {
+    option (common.remove_deprecated_method) = "v1.13";
+    option deprecated = true;
+  }
   rpc Hostname(google.protobuf.Empty) returns (HostnameResponse);
   rpc Kubeconfig(google.protobuf.Empty) returns (stream common.Data);
   rpc List(ListRequest) returns (stream FileInfo);

cmd/talosctl/cmd/talos/apply-config.go

@@ -90,7 +90,7 @@ var applyConfigCmd = &cobra.Command{
 					return err
 				}
 			}
-		} else if applyConfigCmdFlags.Mode.Mode != helpers.InteractiveMode {
+		} else if applyConfigCmdFlags.Mode.Mode != helpers.InteractiveMode { //nolint:staticcheck
 			return errors.New("no filename supplied for configuration")
 		}
 
@@ -103,7 +103,7 @@ var applyConfigCmd = &cobra.Command{
 		}
 
 		return withClient(func(ctx context.Context, c *client.Client) error {
-			if applyConfigCmdFlags.Mode.Mode == helpers.InteractiveMode {
+			if applyConfigCmdFlags.Mode.Mode == helpers.InteractiveMode { //nolint:staticcheck
 				install := installer.NewInstaller()
 				node := GlobalArgs.Nodes[0]
 

cmd/talosctl/pkg/talos/helpers/mode.go

@@ -11,6 +11,7 @@ import (
 	"strings"
 
 	"github.com/siderolabs/gen/maps"
+	"github.com/siderolabs/gen/xslices"
 	"github.com/spf13/cobra"
 
 	"github.com/siderolabs/talos/pkg/cli"
@@ -19,6 +20,9 @@ import (
 
 // InteractiveMode fake mode value for the interactive config mode.
 // Should be never passed to the API.
+//
+// Deprecated: Interactive configuration mode will be removed and
+// should no longer be used.
 const InteractiveMode machine.ApplyConfigurationRequest_Mode = -1
 
 // Mode apply, patch, edit config update mode.
@@ -62,6 +66,9 @@ func (m *Mode) Set(value string) error {
 func (m *Mode) Type() string {
 	options := maps.Keys(m.options)
 	slices.Sort(options)
+	options = xslices.Filter(options, func(opt string) bool {
+		return opt != modeInteractive
+	})
 
 	return strings.Join(options, ", ")
 }

pkg/machinery/api/machine/machine.pb.go

@@ -249,7 +249,7 @@ func (c *Client) ApplyConfiguration(ctx context.Context, req *machineapi.ApplyCo
 
 // GenerateConfiguration implements proto.MachineServiceClient interface.
 func (c *Client) GenerateConfiguration(ctx context.Context, req *machineapi.GenerateConfigurationRequest, callOptions ...grpc.CallOption) (resp *machineapi.GenerateConfigurationResponse, err error) {
-	resp, err = c.MachineClient.GenerateConfiguration(ctx, req, callOptions...)
+	resp, err = c.MachineClient.GenerateConfiguration(ctx, req, callOptions...) //nolint:staticcheck
 
 	return FilterMessages(resp, err)
 }

pkg/machinery/api/machine/machine_grpc.pb.go

@@ -16,20 +16,20 @@ talosctl apply-config [flags]
 ### Options
 
 ```
-      --cert-fingerprint strings                                 list of server certificate fingeprints to accept (defaults to no check)
-  -c, --cluster string                                           Cluster to connect to if a proxy endpoint is used.
-  -p, --config-patch stringArray                                 the list of config patches to apply to the local config file before sending it to the node
-      --context string                                           Context to be used in command
-      --dry-run                                                  check how the config change will be applied in dry-run mode
-  -e, --endpoints strings                                        override default endpoints in Talos configuration
-  -f, --file string                                              the filename of the updated configuration
-  -h, --help                                                     help for apply-config
-  -i, --insecure                                                 apply the config using the insecure (encrypted with no auth) maintenance service
-  -m, --mode auto, interactive, no-reboot, reboot, staged, try   apply config mode (default auto)
-  -n, --nodes strings                                            target the specified nodes
-      --siderov1-keys-dir string                                 The path to the SideroV1 auth PGP keys directory. Defaults to 'SIDEROV1_KEYS_DIR' env variable if set, otherwise '$HOME/.talos/keys'. Only valid for Contexts that use SideroV1 auth.
-      --talosconfig string                                       The path to the Talos configuration file. Defaults to 'TALOSCONFIG' env variable if set, otherwise '$HOME/.talos/config' and '/var/run/secrets/talos.dev/config' in order.
-      --timeout duration                                         the config will be rolled back after specified timeout (if try mode is selected) (default 1m0s)
+      --cert-fingerprint strings                    list of server certificate fingeprints to accept (defaults to no check)
+  -c, --cluster string                              Cluster to connect to if a proxy endpoint is used.
+  -p, --config-patch stringArray                    the list of config patches to apply to the local config file before sending it to the node
+      --context string                              Context to be used in command
+      --dry-run                                     check how the config change will be applied in dry-run mode
+  -e, --endpoints strings                           override default endpoints in Talos configuration
+  -f, --file string                                 the filename of the updated configuration
+  -h, --help                                        help for apply-config
+  -i, --insecure                                    apply the config using the insecure (encrypted with no auth) maintenance service
+  -m, --mode auto, no-reboot, reboot, staged, try   apply config mode (default auto)
+  -n, --nodes strings                               target the specified nodes
+      --siderov1-keys-dir string                    The path to the SideroV1 auth PGP keys directory. Defaults to 'SIDEROV1_KEYS_DIR' env variable if set, otherwise '$HOME/.talos/keys'. Only valid for Contexts that use SideroV1 auth.
+      --talosconfig string                          The path to the Talos configuration file. Defaults to 'TALOSCONFIG' env variable if set, otherwise '$HOME/.talos/config' and '/var/run/secrets/talos.dev/config' in order.
+      --timeout duration                            the config will be rolled back after specified timeout (if try mode is selected) (default 1m0s)
 ```
 
 ### SEE ALSO