Skip to content

Conversation

@hrntknr
Copy link
Member

@hrntknr hrntknr commented Aug 24, 2025

Summary

Replace ctx.Done() with proper Wait() method calls in proxy and transparent backend tests to ensure proper cleanup and synchronization.

Type of Change

  • fix: A bug fix

Related Issues

Replace ctx.Done() with proper Wait() method calls in proxy and transparent
backend tests to ensure proper cleanup and synchronization.
Copilot AI review requested due to automatic review settings August 24, 2025 17:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes test synchronization issues by replacing incorrect context.Done() usage with proper Wait() method calls in backend tests. The changes ensure proper cleanup and synchronization when testing backend lifecycle management.

  • Replace ctx.Done() with be.Wait() in transparent backend test
  • Replace ctx.Done() with pb.Wait() in proxy backend test

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pkg/backend/transparent_test.go Updates test goroutine to use backend's Wait() method instead of context.Done()
pkg/backend/proxy_test.go Updates test goroutine to use proxy backend's Wait() method instead of context.Done()

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Aug 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@hrntknr hrntknr merged commit 47ed79f into sigbit:main Aug 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant