feat: support glob patterns for OIDC allowed users #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds glob pattern support for OIDC allowed users, enabling more flexible user authorization patterns like *@example.com while maintaining backward compatibility with exact matching.
- Adds new
--oidc-allowed-users-globconfiguration option that accepts glob patterns - Implements custom string splitting with escape sequences to handle commas in patterns
- Updates OIDC provider to check both exact matches and glob patterns during authorization
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
pkg/auth/oidc.go |
Core implementation of glob pattern matching in OIDC provider |
pkg/auth/oidc_test.go |
Test coverage for glob pattern functionality |
pkg/mcp-proxy/main.go |
Function signature update to pass glob patterns parameter |
main.go |
CLI argument parsing and string splitting utility for glob patterns |
main_test.go |
Test coverage for new utility functions |
go.mod |
Addition of gobwas/glob dependency |
docs/ |
Documentation updates explaining glob pattern usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- Add OIDC_ALLOWED_USERS_GLOB flag/env to allow user authorization via glob patterns - Compile and evaluate patterns with github.com/gobwas/glob - Preserve exact match checks (OIDC_ALLOWED_USERS) and fall back to globs - Introduce splitWithEscapes to parse comma-separated values with escaped delimiters - Wire through CLI flags and pkg/mcp-proxy - Add tests for glob matching and helper parsing - Update README and docs to document new option Backward compatible: when no exact or glob rules are set, all users are allowed (as before).
Also tidy OIDC glob pattern test formatting.
hrntknr
force-pushed
the
feat/oidc-allowed-users-glob
branch
from
2a19adf to
0e02a3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds glob pattern support for OIDC allowed users.\n\n- Supports patterns like @example.com and alice\n- Preserves existing exact-match behavior for backwards compatibility\n\nPlease let me know if you prefer a different title or wording.