Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work #1

Closed
pjebs opened this issue Mar 4, 2022 · 5 comments
Closed

Doesn't work #1

pjebs opened this issue Mar 4, 2022 · 5 comments

Comments

@pjebs
Copy link

pjebs commented Mar 4, 2022

Your site doesn't seem to work for https://github.com/rocketlaunchr/dataframe-go

@siggy
Copy link
Owner

siggy commented Mar 5, 2022

dataframe-go repo is missing go.sum:

$ go install github.com/loov/goda@v0.4.3
$ git clone https://github.com/rocketlaunchr/dataframe-go
$ cd dataframe-go
$ goda graph -short -cluster ./...
go [-e -json -compiled=true -test=false -export=false -deps=true -find=false -- ./...]: exit status 1: go: cloud.google.com/go@v0.57.0: missing go.sum entry; to add it:
	go mod download cloud.google.com/go
go: cloud.google.com/go@v0.57.0: missing go.sum entry; to add it:
	go mod download cloud.google.com/go

@pjebs
Copy link
Author

pjebs commented Mar 5, 2022

You don't need a go.sum

@pjebs
Copy link
Author

pjebs commented Mar 5, 2022

https://github.com/golang/go/wiki/Modules#is-gosum-a-lock-file-why-does-gosum-include-information-for-module-versions-i-am-no-longer-using

No, go.sum is not a lock file. The go.mod files in a build provide enough information for 100% reproducible builds

@siggy
Copy link
Owner

siggy commented Mar 6, 2022

It's true go.sum is not necessary for builds, but that's like saying passwords are not necessary for websites. Yes you can technically set it up that way, but it's extremely ill advised from a security standpoint.

Two things per my first comment:

  1. The failure you reported is coming from a mature Go ecosystem tool, goda, which itself gets the error from the golang/go repo, which (correctly) requires a go.sum when calling goModSummary:

  2. If you just want a dependency graph of that repo, you can simply run the commands I provided in my first comment.

More info: https://go.dev/ref/mod#authenticating

@pjebs pjebs closed this as completed Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants