Skip to content

[mod_event_socket] Fix hangup race with listener_thread of socket application in async mode #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2020
Merged

[mod_event_socket] Fix hangup race with listener_thread of socket application in async mode #636

merged 1 commit into from
May 18, 2020

Conversation

andywolk
Copy link
Contributor

No description provided.

@andywolk andywolk added the bug Something isn't working label May 14, 2020
@andywolk andywolk requested a review from mjerris May 14, 2020 19:08
@andywolk andywolk linked an issue May 14, 2020 that may be closed by this pull request
crashed FreeSWITCH version: 1.10.3-release+git~20200511T105455Z~129de34d84~64bit[Program terminated with signal SIGSEGV, Segmentation fault.] #635
Closed
@signalwire-ci
Copy link

signalwire-ci bot commented May 14, 2020

Scan-build compilation failed: https://artifacts.signalwire.com/drone/signalwire/freeswitch/963/scan-build-result.txt

@andywolk andywolk force-pushed the listener-hangup-race branch from 322c95c to 713e01e Compare May 14, 2020 19:15
@mjerris mjerris mentioned this pull request May 14, 2020
Closed
@andywolk andywolk linked an issue May 14, 2020 that may be closed by this pull request
Crashing FreeSWITCH version: 1.10.2-release+git~20191231T140119Z~f7bdd3845a~64bit[Program terminated with signal SIGABRT, Aborted.] #612
Closed
This was referenced May 14, 2020
Closed
Closed
@mjerris mjerris force-pushed the listener-hangup-race branch from 713e01e to 838f62a Compare May 15, 2020 21:18
@zek
Copy link

zek commented May 18, 2020

Is this somehow related to #580

@kkbhanu
Copy link

kkbhanu commented May 18, 2020

First crash:
Fscrashed with load 1700 + calls in conference, i have updated with mentioned code above.
https://github.com/bee-jarvis/FSCrashes/blob/master/20200518T055728Z-bt.txt

Second Crash:
https://github.com/bee-jarvis/FSCrashes/blob/master/20200518T070147Z-bt.txt
Senario:
more than 3 conferences created with 900+ members given conference hup all and immediately initiated conference call, or tried to execute fs commands.
Result: crashed. calls were not released.

@andywolk
Copy link
Contributor Author

@bee-jarvis What exactly do you do to reproduce this?

@andywolk
Copy link
Contributor Author

@bee-jarvis Please try compiling with ./configure --enable-address-sanitizer. It will log memory errors when running.
OR another option is to run under valgrind

@kkbhanu
Copy link

kkbhanu commented May 18, 2020

@andywolk I am doing calls with event socket and adding into conference more than 900+ members i have created 3 conferences and made conference hup all and immediately trying to make another conference call.

@andywolk
Copy link
Contributor Author

@bee-jarvis Let's move our discussion to a separate issue. Seems like your core dumps are unrelated to mod_event_socket.

@andywolk andywolk merged commit 91f5434 into master May 18, 2020
@andywolk andywolk deleted the listener-hangup-race branch May 18, 2020 17:22
@kkbhanu kkbhanu mentioned this pull request May 26, 2020
Open
winsock added a commit to percipia/eslgo that referenced this pull request Oct 6, 2020
@winsock
Fix for issue #2 caused by a FreeSWITCH bug
0006128 
It was fixed in their code base 22 days ago and the latest release is 29 days ago(1.10.3). We will have to wait for the next release before
signalwire/freeswitch#636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjerris mjerris mjerris approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@andywolk @zek @kkbhanu @mjerris