Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mod_opusfile] fix compiling write file support #719

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

jelmd
Copy link
Contributor

@jelmd jelmd commented Jun 30, 2020

fix #718 : honor $OPUSFILE_ENCODE_CFLAGS and -DHAVE_OPUSFILE_ENCODE when compiling mod_opusfile.c

@dragos-oancea
Copy link
Contributor

can you change the commit message to add square brackets ? [mod_opusfile]

@jelmd
Copy link
Contributor Author

jelmd commented Jul 2, 2020

You mean as prefix? Instead of mod_opusfile: use [mod_opusfile]?

@dragos-oancea
Copy link
Contributor

yes...like the other commit messages are.

@jelmd jelmd force-pushed the fix_mod_opusfile branch from 33598dc to f7412bc Compare July 2, 2020 15:11
@andywolk andywolk changed the title mod_opusfile: fix compiling write file support (fixes #718) [mod_opusfile] fix compiling write file support Jul 8, 2020
@andywolk
Copy link
Contributor

andywolk commented Jul 8, 2020

Please remove the fixes part from the commit message.

@andywolk andywolk merged commit 466a455 into signalwire:master Aug 4, 2020
@andywolk andywolk added the bug Something isn't working label Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mod_opusfile: Makefile.am does not honor configure vars
3 participants