Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule Deneb on mainnet #5233

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Schedule Deneb on mainnet #5233

merged 3 commits into from
Feb 15, 2024

Conversation

michaelsproul
Copy link
Member

Proposed Changes

Schedule Deneb for epoch 269568 as per ethereum/consensus-specs#3597.

Additional Info

I copied the mainnet.yaml file over our config.yaml file and then made the following tweaks:

  • Deleted config for future forks like EIP6110, whisk, etc
  • Reinstated ATTESTATION_SUBNET_SHUFFLING_PREFIX_BITS which seems to be a non-standard config we are using.

This update also resulted in the deletion of TRANSITION_TOTAL_DIFFICULTY: 4294967296 which was leftover junk from a prior config – an outdated name for TERMINAL_TOTAL_DIFFICULTY.

Some other parameters were introduced which we don't read, e.g. REORG_HEAD_WEIGHT_THRESHOLD which will be (eventually) added in:

Another class of parameters like EPOCHS_PER_SUBNET_SUBSCRIPTION had defaults, and we are now specify them explicitly.

@michaelsproul michaelsproul added ready-for-review The code is ready for review v5.0.0 Q1 2024 labels Feb 14, 2024
@michaelsproul
Copy link
Member Author

Getting the CLI tests to pass required some hacking on --allow-insecure-genesis-sync. A bit annoying and could probably be done in a cleaner way in future.

@realbigsean
Copy link
Member

Getting the CLI tests to pass required some hacking on --allow-insecure-genesis-sync. A bit annoying and could probably be done in a cleaner way in future.

That is annoying but seems good for now

Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@realbigsean realbigsean added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 15, 2024
@michaelsproul
Copy link
Member Author

@Mergifyio queue

Copy link

mergify bot commented Feb 15, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@michaelsproul
Copy link
Member Author

@Mergifyio requeue

Copy link

mergify bot commented Feb 15, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Feb 15, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 0e819fa

mergify bot added a commit that referenced this pull request Feb 15, 2024
mergify bot added a commit that referenced this pull request Feb 15, 2024
@mergify mergify bot merged commit 0e819fa into unstable Feb 15, 2024
29 checks passed
@mergify mergify bot deleted the schedule-dencun branch February 15, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v5.0.0 Q1 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants