-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schedule Deneb on mainnet #5233
Conversation
Getting the CLI tests to pass required some hacking on |
That is annoying but seems good for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
@Mergifyio requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 0e819fa |
Proposed Changes
Schedule Deneb for epoch 269568 as per ethereum/consensus-specs#3597.
Additional Info
I copied the
mainnet.yaml
file over ourconfig.yaml
file and then made the following tweaks:ATTESTATION_SUBNET_SHUFFLING_PREFIX_BITS
which seems to be a non-standard config we are using.This update also resulted in the deletion of
TRANSITION_TOTAL_DIFFICULTY: 4294967296
which was leftover junk from a prior config – an outdated name forTERMINAL_TOTAL_DIFFICULTY
.Some other parameters were introduced which we don't read, e.g.
REORG_HEAD_WEIGHT_THRESHOLD
which will be (eventually) added in:Another class of parameters like
EPOCHS_PER_SUBNET_SUBSCRIPTION
had defaults, and we are now specify them explicitly.