Add secondary region to API Keys GlobalTable #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know whether we use this at all, but in case the way we back up the data uses the stream, I set it to send the new value. Documentation is here: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-dynamodb-globaltable-streamspecification.html
jason-jackson
approved these changes
May 23, 2023
| u2fTable: ${self:custom.namespace}_u2f | ||
| dev_env: staging | ||
| prod_env: production | ||
| secondaryRegion: ${env:AWS_REGION_SECONDARY, "us-west-2"} |
There was a problem hiding this comment.
Just verifying if this is correct to default to.
There was a problem hiding this comment.
Yep. I believe our current general plan is to put our primary AWS infrastructure in us-east-2 (to reduce the chances of both our infrastructure and the us-east-1 control planes being down at the same time) and to put our secondary infrastructure in us-west-2 (because it's cheaper than us-west-1). Thanks for checking.
briskt
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
StreamSpecificationGlobalTable property