Skip to content

Add secondary region to API Keys GlobalTable #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2023
Merged

Add secondary region to API Keys GlobalTable #112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdf544f
Add GlobalTable replica in secondary region (defaulting to us-west-2)
forevermatt May 23, 2023
edca2e2
Add the required `StreamSpecification` GlobalTable property
forevermatt May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions serverless.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ custom:
u2fTable: ${self:custom.namespace}_u2f
dev_env: staging
prod_env: production
secondaryRegion: ${env:AWS_REGION_SECONDARY, "us-west-2"}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just verifying if this is correct to default to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. I believe our current general plan is to put our primary AWS infrastructure in us-east-2 (to reduce the chances of both our infrastructure and the us-east-1 control planes being down at the same time) and to put our secondary infrastructure in us-west-2 (because it's cheaper than us-west-1). Thanks for checking.


functions:
apiKeyActivate:
Expand Down Expand Up @@ -214,6 +215,18 @@ resources:
Value: "shared"
- Key: "managed_by"
Value: "serverless"
- Region: ${self:custom.secondaryRegion}
Tags:
- Key: "itse_app_name"
Value: ${self:service}
- Key: "itse_app_env"
Value: ${self:custom.${sls:stage}_env}
- Key: "itse_app_customer"
Value: "shared"
- Key: "managed_by"
Value: "serverless"
StreamSpecification:
StreamViewType: NEW_IMAGE
TableName: ${self:custom.apiKeyTable}_global
ApiKeyDynamoDbTable:
Type: AWS::DynamoDB::Table
Expand Down