Skip to content

CVR-788 fix warnings #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 9, 2024
Merged

CVR-788 fix warnings #273

merged 5 commits into from
Jul 9, 2024

Conversation

hobbitronics
Copy link
Contributor

Fixed

  • fix (!) Plugin svelte: A11y: noninteractive element cannot have nonnegative tabIndex value
  • fix (!) Plugin svelte: A11y:
    with click, mousedown, mouseup, keypress handlers must have an ARIA role
  • fix (!) Plugin svelte: A11y:
    with dragenter, dragleave, dragover, drop handlers must have an ARIA role
  • fix (!) Plugin svelte: A11y: Non-interactive element
  • should not be assigned mouse or keyboard event listeners.
  • fix (!) Plugin svelte: A11y: noninteractive element cannot have nonnegative tabIndex value

Feature branch checklist

  • Documentation (README, etc.)
  • Run make format, make dry and make install

@hobbitronics hobbitronics requested a review from a team July 8, 2024 02:38
@hobbitronics hobbitronics changed the title Feature/fix warnings CVR-788 fix warnings Jul 8, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

briskt
briskt approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@briskt briskt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand what I'm looking at, but nothing looks alarming.

@hobbitronics
Copy link
Contributor Author

I don't really understand what I'm looking at, but nothing looks alarming.

Which parts? If you'd to understand better I am happy to go through any changes.

@hobbitronics hobbitronics merged commit 5bdf1c2 into develop Jul 9, 2024
@hobbitronics hobbitronics deleted the feature/fix-warnings branch July 9, 2024 00:05
@briskt
Copy link
Contributor

briskt commented Jul 9, 2024

I don't really understand what I'm looking at, but nothing looks alarming.

Which parts? If you'd to understand better I am happy to go through any changes.

Thanks. I'll just let someone else review the release PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hobbitronics @briskt