Skip to content

CVR-788 fix warnings #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 9, 2024
Merged

CVR-788 fix warnings #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
58b599f
fix(Card): fix Card aria role warn
hobbitronics Jul 8, 2024
d01d097
fix(FileDropArea): fix aria role warning
hobbitronics Jul 8, 2024
e698def
make Drawer story links that work
hobbitronics Jul 8, 2024
ba4798d
fix(Types): stop using deprecated svelte types
hobbitronics Jul 8, 2024
ca3778e
fix(Item): fix aria warnings in List Item
hobbitronics Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 25 additions & 26 deletions components/custom/FileDropArea/FileDropArea.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,36 +73,35 @@ form > * {
}
</style>

<div
<form
id="drop-area"
class="br-8px {$$props.class || ''}"
class="br-8px flex justify-between align-items-center py-1 px-1 {$$props.class || ''}"
class:highlighted
on:dragenter|preventDefault|stopPropagation={highlight}
on:dragleave|preventDefault|stopPropagation={unhighlight}
on:dragover|preventDefault|stopPropagation={highlight}
on:drop|preventDefault|stopPropagation={handleDrop}
class:column={!isAboveMobile()}
>
<form class="flex justify-between align-items-center my-1 px-1" class:column={!isAboveMobile()}>
{#if !uploading}
<input
bind:this={fileInput}
type="file"
id="fileElem"
multiple
accept={mimeType}
disabled={uploading}
on:change={() => handleFiles(fileInput.files)}
/>
{/if}
<label
class="mdc-button m-8px"
for="fileElem"
class:custom-text-button={raised}
class:mdc-button--outlined={outlined}
class:disabled={uploading}
class:mdc-button--raised={raised}>Choose files</label
>
<div class="m-8px">or drop files here</div>
<i class="material-icons icon m-8px" id="upload-icon">cloud_upload</i>
</form>
</div>
{#if !uploading}
<input
bind:this={fileInput}
type="file"
id="fileElem"
multiple
accept={mimeType}
disabled={uploading}
on:change={() => handleFiles(fileInput.files)}
/>
{/if}
<label
class="mdc-button m-8px"
for="fileElem"
class:custom-text-button={raised}
class:mdc-button--outlined={outlined}
class:disabled={uploading}
class:mdc-button--raised={raised}>Choose files</label
>
<div class="m-8px">or drop files here</div>
<i class="material-icons icon m-8px" id="upload-icon">cloud_upload</i>
</form>
1 change: 1 addition & 0 deletions components/mdc/Card/Card.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ $: tabindex = isClickable ? 0 : undefined
</style>

<div
role="button"
{tabindex}
class="mdc-card mdc-typography {$$props.class || ''}"
style="background-color: {color}"
Expand Down
47 changes: 22 additions & 25 deletions components/mdc/List/Item.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,35 +51,32 @@ img {
class:mdc-deprecated-list-item--activated={activated}
class:mdc-deprecated-list-item--disabled={nonInteractive}
data-mdc-dialog-action={$$props['data-mdc-dialog-action']}
on:click
on:keydown
on:keypress
on:keyup
{tabindex}
>
{#if graphicURL}
<div class="mdc-deprecated-list-item__graphic">
<img class="br-50" alt={graphicAlt} src={graphicURL} />
</div>
{:else if icon}
<i class="material-icons mdc-deprecated-list-item__graphic" aria-hidden="true">{icon}</i>
{/if}
<div role="button" {tabindex} on:click on:keydown on:keypress on:keyup>
{#if graphicURL}
<div class="mdc-deprecated-list-item__graphic">
<img class="br-50" alt={graphicAlt} src={graphicURL} />
</div>
{:else if icon}
<i class="material-icons mdc-deprecated-list-item__graphic" aria-hidden="true">{icon}</i>
{/if}

<span class="mdc-deprecated-list-item__ripple" />
<span class="mdc-deprecated-list-item__ripple" />

<span class="mdc-deprecated-list-item__text" class:nonInteractive>
{#if primary || secondary}
<span class="mdc-deprecated-list-item__primary-text">{primary}</span>
<span class="mdc-deprecated-list-item__secondary-text">{secondary}</span>
{:else}
{text}
<slot />
{/if}
</span>
<span class="mdc-deprecated-list-item__text" class:nonInteractive>
{#if primary || secondary}
<span class="mdc-deprecated-list-item__primary-text">{primary}</span>
<span class="mdc-deprecated-list-item__secondary-text">{secondary}</span>
{:else}
{text}
<slot />
{/if}
</span>

<div class="mdc-deprecated-list-item__meta">
{meta}
<slot name="meta" />
<div class="mdc-deprecated-list-item__meta">
{meta}
<slot name="meta" />
</div>
</div>
</li>

Expand Down
Loading