Please Pull My Latest Changes and Releases #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: META.yml
Conflicts: META.yml
Measurement:
(script)
use utf8;
my $generator = String::Random->new;
$generator->randregex('[一-龠]{5}') for 1..1000;
(time)
before: 3.63s
after: 1.54s
(CPU environment)
Intel(R) Core(TM) i5-4670 CPU @ 3.40GHz
This may be a bit faster and is also cleaner.
PBP p.108
'use parent' instead of modifying @isa Do not export all symbols by default
PBP p.178
PBP p.349
PBP pp. 73,75
PBP pp. 93,94
These are the perlcriticrc settings I used to get to a clean bill of health.
rand_gen specifies a subroutine coderef that accepts one argument, $max, and return an integer between 0 and $max-1.
This way it will be included ./Build dist | ./Build disttest.
Avoid indirection in the _rand.
README and LICENSE files are a git/hg/etc. and GitHub best practice. See: * https://help.github.com/articles/about-readmes/ * https://help.github.com/articles/licensing-a-repository/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Steven,
please pull my latest changes and releases. Also make sure to pull the tags.
Regards,
-- Shlomi Fish