ENHANCEMENT: rafactor the redirecting form submit to be more explicit #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asking people to remember and set a predefined class is not a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #464
This is just an enhancement, but I'd like to discuss this a bit further.
@ingo or anyone who knows how PJAX stuff works, can you have a look here? I'm not sure what is the best way to do it - this solution seems right from the logical standpoint - we are explicitly requesting what we need. But the expected behaviour is configured on FormAction::create, which means it's quite hidden, and we can't react to user input by branching out to serving different things.
From the programmer's perspective, it would be easier to be able to specify what is served more like with a Director::redirect, where the decision is made at the end of the control flow. Like here: https://github.com/mateusz/sapphire/compare/os7299bis
What do you think?