Skip to content

Adding the no-debug rule #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2021
Merged

Adding the no-debug rule #151

merged 1 commit into from
Oct 12, 2021

Conversation

Mikek2252
Copy link
Contributor

This PR adds the no-debug rule to help users avoid shipping them in production code. This is the implementation for issue #5

@Mikek2252 Mikek2252 added the enhancement New feature or request label Oct 11, 2021
@Mikek2252 Mikek2252 requested a review from Turbo87 October 11, 2021 14:10
Turbo87
Turbo87 approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! 👍

@Mikek2252 Mikek2252 merged commit 93a0547 into master Oct 12, 2021
@Mikek2252 Mikek2252 deleted the no-debug branch October 12, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Turbo87 Turbo87 Turbo87 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mikek2252 @Turbo87