Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Cloudsmith Icon #1071

Merged
merged 4 commits into from Feb 17, 2020
Merged

Add: Cloudsmith Icon #1071

merged 4 commits into from Feb 17, 2020

Conversation

lskillen
Copy link
Contributor

@lskillen lskillen commented Nov 17, 2018 •
edited

Checklist

  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Adds the icon for Cloudsmith, a managed hosted Package Management service.

Official Branding Page:
https://cloudsmith.io/branding/

Cloudsmith exists in Font Awesome 5 as a brand icon (so parity would be great!):
https://fontawesome.com/icons/cloudsmith?style=brands

Thank you! :-)

Full disclosure: I work at Cloudsmith (background included below).

@lskillen lskillen changed the title Request: Cloudsmith Icon Add: Cloudsmith Icon Nov 17, 2018
@birjj

This comment has been minimized.

Sign in to view
@lskillen

This comment has been minimized.

Sign in to view
@ericcornelissen

This comment has been minimized.

Sign in to view
@birjj

This comment has been minimized.

Sign in to view
@ericcornelissen

This comment has been minimized.

Sign in to view
@lskillen

This comment has been minimized.

Sign in to view
@ericcornelissen

This comment has been minimized.

Sign in to view
@davidklebanoff davidklebanoff added the new icon Issues or pull requests for adding a new icon label Feb 12, 2019
@davidklebanoff davidklebanoff added abandoned Pull requests that have been abandoned by the contributor won't add Icon requests or other features that won't be added and removed new icon Issues or pull requests for adding a new icon abandoned Pull requests that have been abandoned by the contributor labels Mar 5, 2019
@lskillen

This comment has been minimized.

Sign in to view
@lskillen lskillen mentioned this pull request Feb 8, 2020
Closed
@ericcornelissen

This comment has been minimized.

Sign in to view
@lskillen

This comment has been minimized.

Sign in to view
@ericcornelissen

This comment has been minimized.

Sign in to view
@lskillen

This comment has been minimized.

Sign in to view
@PeterShaggyNoble PeterShaggyNoble added in discussion There is an ongoing discussion that should be finished before we can continue new icon Issues or pull requests for adding a new icon labels Feb 10, 2020
@ericcornelissen

This comment has been minimized.

Sign in to view
@lskillen

This comment has been minimized.

Sign in to view
@ericcornelissen

This comment has been minimized.

Sign in to view
@runxel

This comment has been minimized.

Sign in to view
@PeterShaggyNoble

This comment has been minimized.

Sign in to view
@PeterShaggyNoble PeterShaggyNoble removed the won't add Icon requests or other features that won't be added label Feb 13, 2020
@lskillen
Copy link
Contributor Author

And thank you @ericcornelissen, @runxel and @PeterShaggyNoble for your balanced analysis! This is/was hard to reason about, and I greatly appreciate your patience as well while determining the fit outcome. 🙌

@ericcornelissen ericcornelissen removed the in discussion There is an ongoing discussion that should be finished before we can continue label Feb 14, 2020
@PeterShaggyNoble
Copy link
Member

Oop! Forgot to actually review this 🤦‍♂

The path doesn't quite fill the canvas, @lskillen - it's 23.897. Once that's fixed, this should be ready to merge in.

Normally, I'd suggest picking the first colour (#12577e) from a branding page when there's no clear preference stated but, as you're a representative of Cloudsmith, I think we're OK to go with your choice! 😆

@lskillen
Copy link
Contributor Author

Oop! Forgot to actually review this 🤦‍♂

The path doesn't quite fill the canvas, @lskillen - it's 23.897. Once that's fixed, this should be ready to merge in.

Normally, I'd suggest picking the first colour (#12577e) from a branding page when there's no clear preference stated but, as you're a representative of Cloudsmith, I think we're OK to go with your choice! 😆

Ha! Thanks @PeterShaggyNoble. #187EB6 is our primary colour. :-)

I'm not quite an SVG/frontend person. Any suggestions on how best to fix the path?

phatbhoy67
phatbhoy67 reviewed Feb 15, 2020
View reviewed changes
Copy link
Contributor

@phatbhoy67 phatbhoy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggested change should fix the height issue @lskillen

icons/cloudsmith.svg Outdated Show resolved Hide resolved
@lskillen @phatbhoy67
Update icons/cloudsmith.svg
506bd49 
Co-Authored-By: phatbhoy67 <phatbhoy67@users.noreply.github.com>
@lskillen
Copy link
Contributor Author

@phatbhoy67 Looks fantastic, thank you. Your help is hugely appreciated!

PeterShaggyNoble
PeterShaggyNoble reviewed Feb 17, 2020
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now. Thanks for your work on it, @lskillen (and @phatbhoy67). I think this is (finally) ready to merge in 🎉

@PeterShaggyNoble PeterShaggyNoble merged commit 02341b9 into simple-icons:develop Feb 17, 2020
@lskillen lskillen deleted the add-cloudsmith branch February 17, 2020 12:38
@ericcornelissen ericcornelissen mentioned this pull request Mar 1, 2020
Merged
ericcornelissen added a commit that referenced this pull request Mar 1, 2020
@ericcornelissen
Release 48 new icons and 14 updated icons (v2.6.0)
dfeaa3b 
# New icons

- YouTube Studio (#2481)
- Cloudsmith (#1071)
- easyJet (#2598)
- Aer Lingus (#2607)
- Ryanair (#2606)
- JSON Web Tokens (#2605)
- Google Earth (#2529)
- SmartThings (#2618)
- GitHub Actions (#2620)
- XAML (#2522)
- Google Street View (#2533, #2707)
- DC (#2534)
- Suzuki (#2630)
- Mitsubishi (#2631)
- General Motors (#2638)
- Tata (#2637)
- Porsche (#2635)
- BMW (#2626)
- LineageOS (#2609)
- Archicad (#2633)
- Stellar (#2613)
- Try It Online (#2622)
- Prezi (#2623)
- The Washington Post (#2655)
- CNN (#2656)
- CloudCannon (#2662)
- Craft CMS (#2666)
- micro:bit (#2624)
- Cesium (#2660)
- Harbor (#2650)
- QIWI (#2669)
- Staffbase (#2673)
- 1001Tracklists (#2678)
- PlayStation 2 (#2679)
- Antena 3 (#2680)
- FIRST (#2681)
- Poly (#2682)
- Spinrilla (#2696)
- Platzi (#2684)
- GitKraken (#2697)
- Threema (#2699)
- Apollo GraphQL (#2589)
- OnStar (#2701)
- Elm (#2702)
- Iconify (#2703)
- Vivino (#2705)
- Pokémon (#2408)
- Hive (#2674)

# Updated icons

- Microsoft Access (#2541)
- Microsoft Excel (#2549)
- Microsoft Office (#2550)
- Microsoft OneDrive (#2551)
- Microsoft OneNote (#2552)
- Microsoft PowerPoint (#2554)
- Microsoft Teams (#2556)
- Wix (#2596)
- Microsoft Outlook (#2553)
- Google Fit (#2707)
- Google Lens (#2707)
- Google Pay (#2707)
- Google Play (#2707)
- Google Wear OS (#2707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterShaggyNoble PeterShaggyNoble PeterShaggyNoble left review comments

@phatbhoy67 phatbhoy67 phatbhoy67 left review comments

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lskillen @birjj @ericcornelissen @runxel @PeterShaggyNoble @phatbhoy67 @davidklebanoff