Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Harbor #2650

Merged
merged 2 commits into from Feb 27, 2020
Merged

Add Harbor #2650

merged 2 commits into from Feb 27, 2020

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Feb 21, 2020 •
edited

Harbor

Issue: Closes #2646

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Colour from website stylesheet.

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Feb 21, 2020
@phatbhoy67
Copy link
Contributor

Hey @PeterShaggyNoble thanks for your work on this one 👍

I'm not sure what is going on here, but the version in the PR is different to the one available in the header of the Harbor website.

One has rounded pieces depicting the light and the top the roof cap, other parts are cut off rather than pointy, and the silhouette is quite different.

Red is website v black PR and version referenced in #2646 👇

rect4760

This website version seems to be the one used elsewhere on Twitter and the on github for the Harbor avatar.

org

@phatbhoy67 phatbhoy67 added the in discussion There is an ongoing discussion that should be finished before we can continue label Feb 21, 2020
@PeterShaggyNoble
Copy link
Member Author

Thanks for the feedback, @phatbhoy67 - I hadn't even looked at the website version. I agree, though, that it's the version we should use. The one on the site has a few issues with gaps between the paths so I'll need to see if I can fix that or find better source file.

image

@PeterShaggyNoble
Copy link
Member Author

Couldn't find another version so did what I could with the one from the website.

@phatbhoy67 phatbhoy67 removed the in discussion There is an ongoing discussion that should be finished before we can continue label Feb 27, 2020
phatbhoy67
phatbhoy67 approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@phatbhoy67 phatbhoy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @PeterShaggyNoble 👍

@phatbhoy67 phatbhoy67 merged commit 0f49fc5 into simple-icons:develop Feb 27, 2020
@ericcornelissen ericcornelissen mentioned this pull request Mar 1, 2020
Merged
ericcornelissen added a commit that referenced this pull request Mar 1, 2020
@ericcornelissen
Release 48 new icons and 14 updated icons (v2.6.0)
dfeaa3b 
# New icons

- YouTube Studio (#2481)
- Cloudsmith (#1071)
- easyJet (#2598)
- Aer Lingus (#2607)
- Ryanair (#2606)
- JSON Web Tokens (#2605)
- Google Earth (#2529)
- SmartThings (#2618)
- GitHub Actions (#2620)
- XAML (#2522)
- Google Street View (#2533, #2707)
- DC (#2534)
- Suzuki (#2630)
- Mitsubishi (#2631)
- General Motors (#2638)
- Tata (#2637)
- Porsche (#2635)
- BMW (#2626)
- LineageOS (#2609)
- Archicad (#2633)
- Stellar (#2613)
- Try It Online (#2622)
- Prezi (#2623)
- The Washington Post (#2655)
- CNN (#2656)
- CloudCannon (#2662)
- Craft CMS (#2666)
- micro:bit (#2624)
- Cesium (#2660)
- Harbor (#2650)
- QIWI (#2669)
- Staffbase (#2673)
- 1001Tracklists (#2678)
- PlayStation 2 (#2679)
- Antena 3 (#2680)
- FIRST (#2681)
- Poly (#2682)
- Spinrilla (#2696)
- Platzi (#2684)
- GitKraken (#2697)
- Threema (#2699)
- Apollo GraphQL (#2589)
- OnStar (#2701)
- Elm (#2702)
- Iconify (#2703)
- Vivino (#2705)
- Pokémon (#2408)
- Hive (#2674)

# Updated icons

- Microsoft Access (#2541)
- Microsoft Excel (#2549)
- Microsoft Office (#2550)
- Microsoft OneDrive (#2551)
- Microsoft OneNote (#2552)
- Microsoft PowerPoint (#2554)
- Microsoft Teams (#2556)
- Wix (#2596)
- Microsoft Outlook (#2553)
- Google Fit (#2707)
- Google Lens (#2707)
- Google Pay (#2707)
- Google Play (#2707)
- Google Wear OS (#2707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phatbhoy67 phatbhoy67 phatbhoy67 approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harbor
2 participants
@PeterShaggyNoble @phatbhoy67