Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft Access #2541

Merged

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Feb 6, 2020

Microsoft Access

Issue: #1585

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Holding off on the rest as I need some help deciding on the source URL for them all:

  1. The icons were sourced at https://uifabricicons.azurewebsites.net/
  2. There is a subset of that font used at https://developer.microsoft.com/en-us/office, and all the icons are visible there
  3. The individual product pages (in this case https://developer.microsoft.com/en-us/access) use that same font subset and, although a product's page doesn't always use its icon anywhere, they do all include the product's colour.

As both the icon and the colour can be retrieved from the individual product pages, I've gone with option 3.
Never mind, just found https://developer.microsoft.com/en-us/fabric#/styles/web/colors/products which includes the exact colour references and, as both icon and colour are available, I think that's a better choice for the source URL too.

@PeterShaggyNoble PeterShaggyNoble added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Feb 6, 2020
@PeterShaggyNoble
Copy link
Member Author

PeterShaggyNoble commented Feb 7, 2020

... Or would one of the colours from the full colour brand icon be a better choice?
https://static2.sharepointonline.com/files/fabric/assets/brand-icons/product/svg/access_48x1.svg in this case.

Never mind, just found https://developer.microsoft.com/en-us/fabric#/styles/web/colors/products which includes the exact colour references and, is both icon and colour are available, I think that's a better choice for the source URL too.

@ericcornelissen ericcornelissen merged commit e8e6a09 into simple-icons:develop Feb 18, 2020
@PeterShaggyNoble PeterShaggyNoble deleted the update/microsoftaccess branch February 19, 2020 09:49
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Feb 20, 2020
3 tasks
ericcornelissen added a commit that referenced this pull request Mar 1, 2020
# New icons

- YouTube Studio (#2481)
- Cloudsmith (#1071)
- easyJet (#2598)
- Aer Lingus (#2607)
- Ryanair (#2606)
- JSON Web Tokens (#2605)
- Google Earth (#2529)
- SmartThings (#2618)
- GitHub Actions (#2620)
- XAML (#2522)
- Google Street View (#2533, #2707)
- DC (#2534)
- Suzuki (#2630)
- Mitsubishi (#2631)
- General Motors (#2638)
- Tata (#2637)
- Porsche (#2635)
- BMW (#2626)
- LineageOS (#2609)
- Archicad (#2633)
- Stellar (#2613)
- Try It Online (#2622)
- Prezi (#2623)
- The Washington Post (#2655)
- CNN (#2656)
- CloudCannon (#2662)
- Craft CMS (#2666)
- micro:bit (#2624)
- Cesium (#2660)
- Harbor (#2650)
- QIWI (#2669)
- Staffbase (#2673)
- 1001Tracklists (#2678)
- PlayStation 2 (#2679)
- Antena 3 (#2680)
- FIRST (#2681)
- Poly (#2682)
- Spinrilla (#2696)
- Platzi (#2684)
- GitKraken (#2697)
- Threema (#2699)
- Apollo GraphQL (#2589)
- OnStar (#2701)
- Elm (#2702)
- Iconify (#2703)
- Vivino (#2705)
- Pokémon (#2408)
- Hive (#2674)

# Updated icons

- Microsoft Access (#2541)
- Microsoft Excel (#2549)
- Microsoft Office (#2550)
- Microsoft OneDrive (#2551)
- Microsoft OneNote (#2552)
- Microsoft PowerPoint (#2554)
- Microsoft Teams (#2556)
- Wix (#2596)
- Microsoft Outlook (#2553)
- Google Fit (#2707)
- Google Lens (#2707)
- Google Pay (#2707)
- Google Play (#2707)
- Google Wear OS (#2707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants