Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pokémon icon #2408

Merged
merged 3 commits into from Mar 1, 2020
Merged

Add Pokémon icon #2408

merged 3 commits into from Mar 1, 2020

Conversation

KovuTheHusky
Copy link
Contributor

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

As a companion PR to #2340.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Jan 19, 2020
@ericcornelissen
Copy link
Contributor

Not a full review but just wanted to say I'm okay (and I think I prefer) the full Pokémon wordmark. That said, the Pokéball is a good alternative (as per this comment) 👍

@PeterShaggyNoble
Copy link
Member

I'd vote for the Pokeball over the full wordmark as it suits our purposes as an icon library better and is iconic enough on its own.

@ericcornelissen
Copy link
Contributor

I'd vote for the Pokeball over the full wordmark as it suits our purposes as an icon library better and is iconic enough on its own.

Although the Pokéball is a fictional brand, I personally feel like it is separate 🤔 Any input from other @simple-icons/maintainers?

@ericcornelissen ericcornelissen added the in discussion There is an ongoing discussion that should be finished before we can continue label Feb 14, 2020
@runxel
Copy link
Member

runxel commented Feb 14, 2020

I'd prefer the wordmark actually...

Copy link
Contributor

@phatbhoy67 phatbhoy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with using the wordmark.

The svg matches @KovuTheHusky, nice work 👍

One thing, why did you choose red for the hex value, I would expect it to be blue or yellow?

@ericcornelissen
Copy link
Contributor

One thing, why did you choose red for the hex value, I would expect it to be blue or yellow?

Good point, I guess red is based on the Pokéball 😆 but indeed yellow or blue are better options if we go with the wordmark. I'm personally in favour of yellow.

@PeterShaggyNoble
Copy link
Member

As a Pokémon "outsider" (far too old for it!), I'd associate yellow with it, as a brand. That, however, may well be influenced by Pikachu being the most well known character.

@ericcornelissen
Copy link
Contributor

It seems there is consensus on yellow so I updated it 👍

That, however, may well be influenced by Pikachu being the most well known character.

I don't even think that is a bad reason to choose yellow 🙃

@ericcornelissen ericcornelissen removed the in discussion There is an ongoing discussion that should be finished before we can continue label Mar 1, 2020
@phatbhoy67
Copy link
Contributor

Thanks for your work on this one @KovuTheHusky and thanks to @ericcornelissen for updating the colour 👍

@phatbhoy67 phatbhoy67 merged commit 8d46dbb into simple-icons:develop Mar 1, 2020
ericcornelissen added a commit that referenced this pull request Mar 1, 2020
# New icons

- YouTube Studio (#2481)
- Cloudsmith (#1071)
- easyJet (#2598)
- Aer Lingus (#2607)
- Ryanair (#2606)
- JSON Web Tokens (#2605)
- Google Earth (#2529)
- SmartThings (#2618)
- GitHub Actions (#2620)
- XAML (#2522)
- Google Street View (#2533, #2707)
- DC (#2534)
- Suzuki (#2630)
- Mitsubishi (#2631)
- General Motors (#2638)
- Tata (#2637)
- Porsche (#2635)
- BMW (#2626)
- LineageOS (#2609)
- Archicad (#2633)
- Stellar (#2613)
- Try It Online (#2622)
- Prezi (#2623)
- The Washington Post (#2655)
- CNN (#2656)
- CloudCannon (#2662)
- Craft CMS (#2666)
- micro:bit (#2624)
- Cesium (#2660)
- Harbor (#2650)
- QIWI (#2669)
- Staffbase (#2673)
- 1001Tracklists (#2678)
- PlayStation 2 (#2679)
- Antena 3 (#2680)
- FIRST (#2681)
- Poly (#2682)
- Spinrilla (#2696)
- Platzi (#2684)
- GitKraken (#2697)
- Threema (#2699)
- Apollo GraphQL (#2589)
- OnStar (#2701)
- Elm (#2702)
- Iconify (#2703)
- Vivino (#2705)
- Pokémon (#2408)
- Hive (#2674)

# Updated icons

- Microsoft Access (#2541)
- Microsoft Excel (#2549)
- Microsoft Office (#2550)
- Microsoft OneDrive (#2551)
- Microsoft OneNote (#2552)
- Microsoft PowerPoint (#2554)
- Microsoft Teams (#2556)
- Wix (#2596)
- Microsoft Outlook (#2553)
- Google Fit (#2707)
- Google Lens (#2707)
- Google Pay (#2707)
- Google Play (#2707)
- Google Wear OS (#2707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants