Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add micro:bit #2624

Merged
merged 3 commits into from Feb 25, 2020
Merged

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Feb 19, 2020

micro:bit

Issue: MDI#4009

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icon taken from SVG in website header. Light green seems to be their primary brand colour so I grabbed the green from this file but there's also #00ed00 which is the starting point of the background gradient of their site and a case could also be made for #001700 seen in the header and footer, which is obtained by layering 90% black over #00ed00.

Alexa rank: 31891

Note: The build has failed due to the : in the brand name, which we don't currently handle. It has been addressed in #2625.

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Feb 19, 2020
@PeterShaggyNoble PeterShaggyNoble added the pending Issues that are pending because of e.g. a scheduled brand update label Feb 19, 2020
@PeterShaggyNoble

This comment has been minimized.

@ericcornelissen

This comment has been minimized.

@ericcornelissen

This comment has been minimized.

@PeterShaggyNoble

This comment has been minimized.

@PeterShaggyNoble

This comment has been minimized.

@ericcornelissen ericcornelissen removed the pending Issues that are pending because of e.g. a scheduled brand update label Feb 23, 2020
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG looks good, judging from the use of their logo on their social media I would expect #00ed00 to be the brand colour. (from the website I would expect #001700, but personally I don't think blue is a good choice.)

_data/simple-icons.json Outdated Show resolved Hide resolved
Co-Authored-By: Eric Cornelissen <ericornelissen@gmail.com>
@ericcornelissen ericcornelissen merged commit 78fe366 into simple-icons:develop Feb 25, 2020
@PeterShaggyNoble PeterShaggyNoble deleted the mircobit branch February 25, 2020 12:07
ericcornelissen added a commit that referenced this pull request Mar 1, 2020
# New icons

- YouTube Studio (#2481)
- Cloudsmith (#1071)
- easyJet (#2598)
- Aer Lingus (#2607)
- Ryanair (#2606)
- JSON Web Tokens (#2605)
- Google Earth (#2529)
- SmartThings (#2618)
- GitHub Actions (#2620)
- XAML (#2522)
- Google Street View (#2533, #2707)
- DC (#2534)
- Suzuki (#2630)
- Mitsubishi (#2631)
- General Motors (#2638)
- Tata (#2637)
- Porsche (#2635)
- BMW (#2626)
- LineageOS (#2609)
- Archicad (#2633)
- Stellar (#2613)
- Try It Online (#2622)
- Prezi (#2623)
- The Washington Post (#2655)
- CNN (#2656)
- CloudCannon (#2662)
- Craft CMS (#2666)
- micro:bit (#2624)
- Cesium (#2660)
- Harbor (#2650)
- QIWI (#2669)
- Staffbase (#2673)
- 1001Tracklists (#2678)
- PlayStation 2 (#2679)
- Antena 3 (#2680)
- FIRST (#2681)
- Poly (#2682)
- Spinrilla (#2696)
- Platzi (#2684)
- GitKraken (#2697)
- Threema (#2699)
- Apollo GraphQL (#2589)
- OnStar (#2701)
- Elm (#2702)
- Iconify (#2703)
- Vivino (#2705)
- Pokémon (#2408)
- Hive (#2674)

# Updated icons

- Microsoft Access (#2541)
- Microsoft Excel (#2549)
- Microsoft Office (#2550)
- Microsoft OneDrive (#2551)
- Microsoft OneNote (#2552)
- Microsoft PowerPoint (#2554)
- Microsoft Teams (#2556)
- Wix (#2596)
- Microsoft Outlook (#2553)
- Google Fit (#2707)
- Google Lens (#2707)
- Google Pay (#2707)
- Google Play (#2707)
- Google Wear OS (#2707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants