Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add easyJet #2598

Merged
merged 2 commits into from Feb 17, 2020
Merged

Add easyJet #2598

merged 2 commits into from Feb 17, 2020

Conversation

runxel
Copy link
Member

@runxel runxel commented Feb 14, 2020

Issue: #2587

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

There was sadly no svg to be found, neither on their website nor Wikipedia.
However it was easy to recreate, since the wordmark is set in Cooper Black. The kerning was adjusted to fit to a higher resolution picture of the logo.
The color #FF751A was lifted from the website's css.

@runxel runxel added the new icon Issues or pull requests for adding a new icon label Feb 14, 2020
@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented Feb 14, 2020

I extracted the wordmark from page 14 of this PDF and converted it to a path and your version (in red) doesn't quite line up. From page 18 ofhat PDF, as well, there are a couple more choices for the colour:

  • #fe5000 from converting the Pantone
  • #ff5700 from converting the CMYK
  • #ff6600

easyJet

@runxel
Copy link
Member Author

runxel commented Feb 14, 2020

Hey @PeterShaggyNoble. thanks for joining in here!
The link to the brand guide is great, I saw it referenced mutliple times but the links were all dead; nice to see you've found it!

However, please do your comparison with the actual logo from the website – you will see that indeed the kerning in the PDF is wrong (it was just set in Cooper Black with no additional kerning done on it).

I'm fine with either of those colors, we just need to agree on one. :D

@PeterShaggyNoble
Copy link
Member

Ah, I completely misread your initial comment, don't know what I think you meant now! Sorry 'bout that.

From past experience, you're much better at comparisons between vector and raster than I so I'll defer to you there, pending a review from one of the other @simple-icons/maintainers, of course.

On the colour: I'd vote #ff6600 as it's provided twice in the brand guidelines. But I also think that your initial choice is an acceptable alternative given that it's also sources from easyJet, if that's the consensus.

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the colour should be #ff6600. also note that it is marked as "Web safe" in the brand guidelines, which is where our icons will likely be use. I also think the version of the logo in the PR is correct (i.e. with kerning).

We could consider updating the URL to something that links to the brand guidelines (even if that link is dead)? @runxel, any suggestions?

@runxel
Copy link
Member Author

runxel commented Feb 15, 2020

#ff6600 it is, then!

We could link to https://easy.com/ ?
I mean, that's the parent page. I am not sure if we should link against the document itself. Pretty sure @PeterShaggyNoble would be concerned of link rot, and actually I am as well in this case.
(Given that this just a basic wordpress link it doesn't really look persistent enough)

@ericcornelissen
Copy link
Contributor

@runxel I think the easyJet website is better than the easy website. I agree that link rot is a potential problem, and linking the PDF itself is not ideal in any case. The main reason I asked for suggestions is because you said earlier:

The link to the brand guide is great, I saw it referenced multiple times but the links were all dead; nice to see you've found it!

So I was wondering if any of the pages where you saw it referenced could be used as a source. If not, then I think this is fine as is.

at least we have a reference to the brand guidelines in this discussion...

@runxel
Copy link
Member Author

runxel commented Feb 17, 2020

The link to the brand guide is great, I saw it referenced multiple times but the links were all dead; nice to see you've found it!

So I was wondering if any of the pages where you saw it referenced could be used as a source. If not, then I think this is fine as is.

Ah, got it, sorry!
Funnily enough, the links were all on unrelated websites (like from fontsinuse.com and therelike).
So yes, best is to stay on easyjet.com, like it was already.

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, let's leave it like this 🙂 I'll leave it to @PeterShaggyNoble to have a last look at this 👍

@PeterShaggyNoble
Copy link
Member

All looks good to me 😃

@PeterShaggyNoble PeterShaggyNoble merged commit 88ac7f5 into simple-icons:develop Feb 17, 2020
@runxel runxel deleted the easyjet branch February 17, 2020 17:31
ericcornelissen added a commit that referenced this pull request Mar 1, 2020
# New icons

- YouTube Studio (#2481)
- Cloudsmith (#1071)
- easyJet (#2598)
- Aer Lingus (#2607)
- Ryanair (#2606)
- JSON Web Tokens (#2605)
- Google Earth (#2529)
- SmartThings (#2618)
- GitHub Actions (#2620)
- XAML (#2522)
- Google Street View (#2533, #2707)
- DC (#2534)
- Suzuki (#2630)
- Mitsubishi (#2631)
- General Motors (#2638)
- Tata (#2637)
- Porsche (#2635)
- BMW (#2626)
- LineageOS (#2609)
- Archicad (#2633)
- Stellar (#2613)
- Try It Online (#2622)
- Prezi (#2623)
- The Washington Post (#2655)
- CNN (#2656)
- CloudCannon (#2662)
- Craft CMS (#2666)
- micro:bit (#2624)
- Cesium (#2660)
- Harbor (#2650)
- QIWI (#2669)
- Staffbase (#2673)
- 1001Tracklists (#2678)
- PlayStation 2 (#2679)
- Antena 3 (#2680)
- FIRST (#2681)
- Poly (#2682)
- Spinrilla (#2696)
- Platzi (#2684)
- GitKraken (#2697)
- Threema (#2699)
- Apollo GraphQL (#2589)
- OnStar (#2701)
- Elm (#2702)
- Iconify (#2703)
- Vivino (#2705)
- Pokémon (#2408)
- Hive (#2674)

# Updated icons

- Microsoft Access (#2541)
- Microsoft Excel (#2549)
- Microsoft Office (#2550)
- Microsoft OneDrive (#2551)
- Microsoft OneNote (#2552)
- Microsoft PowerPoint (#2554)
- Microsoft Teams (#2556)
- Wix (#2596)
- Microsoft Outlook (#2553)
- Google Fit (#2707)
- Google Lens (#2707)
- Google Pay (#2707)
- Google Play (#2707)
- Google Wear OS (#2707)
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Mar 19, 2020
3 tasks
@runxel runxel mentioned this pull request Mar 19, 2020
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants