Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Musescore #1685

Merged
merged 3 commits into from
Oct 5, 2019
Merged

Conversation

foo-dogsquared
Copy link
Contributor

Issue: #1578

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The brand color is simply extracted from the graphics.

I also vectorized the logo with Inkscape.
Fortunately, the graphics is quite simple that not much reduction is present.

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Pull Request looks good overall @foo-dogsquared 👍 Just have a small request for a change and a question regarding the color. See my comments below 🙂

_data/simple-icons.json Outdated Show resolved Hide resolved
icons/musescore.svg Outdated Show resolved Hide resolved
_data/simple-icons.json Show resolved Hide resolved
@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Oct 2, 2019
@ericcornelissen ericcornelissen merged commit 449f4c4 into simple-icons:develop Oct 5, 2019
@ericcornelissen
Copy link
Contributor

Thanks a bunch for you work on this once again @foo-dogsquared 😃

@foo-dogsquared foo-dogsquared deleted the musescore branch October 5, 2019 16:26
birjj added a commit that referenced this pull request Oct 6, 2019
# New icons

- Terraform (#1674)
- Google Scholar (#1677)
- TensorFlow (#1683)
- Skillshare (#1686)
- Eleventy (#1698)
- GreenSock (#1691)
- PyTorch (#1689)
- Qgis (#1697)
- Xiaomi (#1687)
- MuseScore (#1685)
- Gentoo (#1688)
- McAfee (#1700)

# Updated icons
- Laravel (#1692)

# Miscellaneous

- Now available for PHP through packagist (#1611)
- SVG files may no have a final newline (#1682)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants